Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2393)

Unified Diff: cc/layers/painted_overlay_scrollbar_layer.h

Issue 2827163005: Remove scroll layer ids from scrollbar layers (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/painted_overlay_scrollbar_layer.h
diff --git a/cc/layers/painted_overlay_scrollbar_layer.h b/cc/layers/painted_overlay_scrollbar_layer.h
index c71f7b5988a20acd3533587c5420d3f969ab792d..ee305b9874cc3c4cb14839838ca998187f44a4bf 100644
--- a/cc/layers/painted_overlay_scrollbar_layer.h
+++ b/cc/layers/painted_overlay_scrollbar_layer.h
@@ -22,7 +22,6 @@ class CC_EXPORT PaintedOverlayScrollbarLayer : public ScrollbarLayerInterface,
static scoped_refptr<PaintedOverlayScrollbarLayer> Create(
std::unique_ptr<Scrollbar> scrollbar,
- int scroll_layer_id,
ElementId scroll_element_id = ElementId());
bool OpacityCanAnimateOnImplThread() const override;
@@ -31,8 +30,7 @@ class CC_EXPORT PaintedOverlayScrollbarLayer : public ScrollbarLayerInterface,
// ScrollbarLayerInterface
ElementId scroll_element_id() const override;
- // TODO(pdr): Remove layer_id and refactor scrollbars to just use element ids.
- void SetScrollInfo(int layer_id, ElementId element_id) override;
+ void SetScrollElementId(ElementId element_id) override;
ScrollbarOrientation orientation() const override;
// Layer interface
@@ -42,7 +40,6 @@ class CC_EXPORT PaintedOverlayScrollbarLayer : public ScrollbarLayerInterface,
protected:
PaintedOverlayScrollbarLayer(std::unique_ptr<Scrollbar> scrollbar,
- int scroll_layer_id,
ElementId scroll_element_id);
~PaintedOverlayScrollbarLayer() override;
@@ -61,7 +58,6 @@ class CC_EXPORT PaintedOverlayScrollbarLayer : public ScrollbarLayerInterface,
bool PaintThumbIfNeeded();
std::unique_ptr<Scrollbar> scrollbar_;
- int scroll_layer_id_;
ElementId scroll_element_id_;
int thumb_thickness_;

Powered by Google App Engine
This is Rietveld 408576698