Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: cc/blink/web_scrollbar_layer_impl.cc

Issue 2827163005: Remove scroll layer ids from scrollbar layers (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/blink/web_scrollbar_layer_impl.h" 5 #include "cc/blink/web_scrollbar_layer_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "cc/blink/scrollbar_impl.h" 10 #include "cc/blink/scrollbar_impl.h"
(...skipping 24 matching lines...) Expand all
35 WebScrollbarLayerImpl::WebScrollbarLayerImpl( 35 WebScrollbarLayerImpl::WebScrollbarLayerImpl(
36 std::unique_ptr<blink::WebScrollbar> scrollbar, 36 std::unique_ptr<blink::WebScrollbar> scrollbar,
37 blink::WebScrollbarThemePainter painter, 37 blink::WebScrollbarThemePainter painter,
38 std::unique_ptr<blink::WebScrollbarThemeGeometry> geometry, 38 std::unique_ptr<blink::WebScrollbarThemeGeometry> geometry,
39 bool is_overlay) 39 bool is_overlay)
40 : layer_(is_overlay 40 : layer_(is_overlay
41 ? new WebLayerImpl(PaintedOverlayScrollbarLayer::Create( 41 ? new WebLayerImpl(PaintedOverlayScrollbarLayer::Create(
42 base::MakeUnique<ScrollbarImpl>(std::move(scrollbar), 42 base::MakeUnique<ScrollbarImpl>(std::move(scrollbar),
43 painter, 43 painter,
44 std::move(geometry)), 44 std::move(geometry)),
45 cc::Layer::INVALID_ID,
46 cc::ElementId())) 45 cc::ElementId()))
47 : new WebLayerImpl(PaintedScrollbarLayer::Create( 46 : new WebLayerImpl(PaintedScrollbarLayer::Create(
48 base::MakeUnique<ScrollbarImpl>(std::move(scrollbar), 47 base::MakeUnique<ScrollbarImpl>(std::move(scrollbar),
49 painter, 48 painter,
50 std::move(geometry)), 49 std::move(geometry)),
51 cc::Layer::INVALID_ID,
52 cc::ElementId()))) {} 50 cc::ElementId()))) {}
53 51
54 WebScrollbarLayerImpl::WebScrollbarLayerImpl( 52 WebScrollbarLayerImpl::WebScrollbarLayerImpl(
55 blink::WebScrollbar::Orientation orientation, 53 blink::WebScrollbar::Orientation orientation,
56 int thumb_thickness, 54 int thumb_thickness,
57 int track_start, 55 int track_start,
58 bool is_left_side_vertical_scrollbar) 56 bool is_left_side_vertical_scrollbar)
59 : layer_(new WebLayerImpl( 57 : layer_(new WebLayerImpl(
60 SolidColorScrollbarLayer::Create(ConvertOrientation(orientation), 58 SolidColorScrollbarLayer::Create(ConvertOrientation(orientation),
61 thumb_thickness, 59 thumb_thickness,
62 track_start, 60 track_start,
63 is_left_side_vertical_scrollbar, 61 is_left_side_vertical_scrollbar,
64 cc::Layer::INVALID_ID,
65 cc::ElementId()))) {} 62 cc::ElementId()))) {}
66 63
67 WebScrollbarLayerImpl::~WebScrollbarLayerImpl() { 64 WebScrollbarLayerImpl::~WebScrollbarLayerImpl() {
68 } 65 }
69 66
70 blink::WebLayer* WebScrollbarLayerImpl::Layer() { 67 blink::WebLayer* WebScrollbarLayerImpl::Layer() {
71 return layer_.get(); 68 return layer_.get();
72 } 69 }
73 70
74 void WebScrollbarLayerImpl::SetScrollLayer(blink::WebLayer* layer) { 71 void WebScrollbarLayerImpl::SetScrollLayer(blink::WebLayer* layer) {
75 cc::Layer* scroll_layer = 72 cc::Layer* scroll_layer =
76 layer ? static_cast<WebLayerImpl*>(layer)->layer() : 0; 73 layer ? static_cast<WebLayerImpl*>(layer)->layer() : nullptr;
77 layer_->layer()->ToScrollbarLayer()->SetScrollInfo( 74 layer_->layer()->ToScrollbarLayer()->SetScrollElementId(
78 scroll_layer ? scroll_layer->id() : cc::Layer::INVALID_ID,
79 scroll_layer ? scroll_layer->element_id() : cc::ElementId()); 75 scroll_layer ? scroll_layer->element_id() : cc::ElementId());
80 } 76 }
81 77
82 } // namespace cc_blink 78 } // namespace cc_blink
OLDNEW
« no previous file with comments | « no previous file | cc/input/scrollbar_animation_controller_unittest.cc » ('j') | cc/layers/scrollbar_layer_impl_base.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698