Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: cc/layers/painted_overlay_scrollbar_layer.h

Issue 2827163005: Remove scroll layer ids from scrollbar layers (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_ 5 #ifndef CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_
6 #define CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_ 6 #define CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "cc/cc_export.h" 9 #include "cc/cc_export.h"
10 #include "cc/input/scrollbar.h" 10 #include "cc/input/scrollbar.h"
11 #include "cc/layers/layer.h" 11 #include "cc/layers/layer.h"
12 #include "cc/layers/scrollbar_layer_interface.h" 12 #include "cc/layers/scrollbar_layer_interface.h"
13 #include "cc/layers/scrollbar_theme_painter.h" 13 #include "cc/layers/scrollbar_theme_painter.h"
14 #include "cc/resources/scoped_ui_resource.h" 14 #include "cc/resources/scoped_ui_resource.h"
15 15
16 namespace cc { 16 namespace cc {
17 17
18 class CC_EXPORT PaintedOverlayScrollbarLayer : public ScrollbarLayerInterface, 18 class CC_EXPORT PaintedOverlayScrollbarLayer : public ScrollbarLayerInterface,
19 public Layer { 19 public Layer {
20 public: 20 public:
21 std::unique_ptr<LayerImpl> CreateLayerImpl(LayerTreeImpl* tree_impl) override; 21 std::unique_ptr<LayerImpl> CreateLayerImpl(LayerTreeImpl* tree_impl) override;
22 22
23 static scoped_refptr<PaintedOverlayScrollbarLayer> Create( 23 static scoped_refptr<PaintedOverlayScrollbarLayer> Create(
24 std::unique_ptr<Scrollbar> scrollbar, 24 std::unique_ptr<Scrollbar> scrollbar,
25 int scroll_layer_id,
26 ElementId scroll_element_id = ElementId()); 25 ElementId scroll_element_id = ElementId());
27 26
28 bool OpacityCanAnimateOnImplThread() const override; 27 bool OpacityCanAnimateOnImplThread() const override;
29 bool AlwaysUseActiveTreeOpacity() const override; 28 bool AlwaysUseActiveTreeOpacity() const override;
30 ScrollbarLayerInterface* ToScrollbarLayer() override; 29 ScrollbarLayerInterface* ToScrollbarLayer() override;
31 30
32 // ScrollbarLayerInterface 31 // ScrollbarLayerInterface
33 ElementId scroll_element_id() const override; 32 ElementId scroll_element_id() const override;
34 // TODO(pdr): Remove layer_id and refactor scrollbars to just use element ids. 33 void SetScrollElementId(ElementId element_id) override;
35 void SetScrollInfo(int layer_id, ElementId element_id) override;
36 ScrollbarOrientation orientation() const override; 34 ScrollbarOrientation orientation() const override;
37 35
38 // Layer interface 36 // Layer interface
39 bool Update() override; 37 bool Update() override;
40 void SetLayerTreeHost(LayerTreeHost* host) override; 38 void SetLayerTreeHost(LayerTreeHost* host) override;
41 void PushPropertiesTo(LayerImpl* layer) override; 39 void PushPropertiesTo(LayerImpl* layer) override;
42 40
43 protected: 41 protected:
44 PaintedOverlayScrollbarLayer(std::unique_ptr<Scrollbar> scrollbar, 42 PaintedOverlayScrollbarLayer(std::unique_ptr<Scrollbar> scrollbar,
45 int scroll_layer_id,
46 ElementId scroll_element_id); 43 ElementId scroll_element_id);
47 ~PaintedOverlayScrollbarLayer() override; 44 ~PaintedOverlayScrollbarLayer() override;
48 45
49 private: 46 private:
50 gfx::Rect OriginThumbRectForPainting() const; 47 gfx::Rect OriginThumbRectForPainting() const;
51 48
52 template <typename T> 49 template <typename T>
53 bool UpdateProperty(T value, T* prop) { 50 bool UpdateProperty(T value, T* prop) {
54 if (*prop == value) 51 if (*prop == value)
55 return false; 52 return false;
56 *prop = value; 53 *prop = value;
57 SetNeedsPushProperties(); 54 SetNeedsPushProperties();
58 return true; 55 return true;
59 } 56 }
60 57
61 bool PaintThumbIfNeeded(); 58 bool PaintThumbIfNeeded();
62 59
63 std::unique_ptr<Scrollbar> scrollbar_; 60 std::unique_ptr<Scrollbar> scrollbar_;
64 int scroll_layer_id_;
65 ElementId scroll_element_id_; 61 ElementId scroll_element_id_;
66 62
67 int thumb_thickness_; 63 int thumb_thickness_;
68 int thumb_length_; 64 int thumb_length_;
69 gfx::Point location_; 65 gfx::Point location_;
70 gfx::Rect track_rect_; 66 gfx::Rect track_rect_;
71 67
72 gfx::Rect aperture_; 68 gfx::Rect aperture_;
73 69
74 std::unique_ptr<ScopedUIResource> thumb_resource_; 70 std::unique_ptr<ScopedUIResource> thumb_resource_;
75 71
76 DISALLOW_COPY_AND_ASSIGN(PaintedOverlayScrollbarLayer); 72 DISALLOW_COPY_AND_ASSIGN(PaintedOverlayScrollbarLayer);
77 }; 73 };
78 74
79 } // namespace cc 75 } // namespace cc
80 76
81 #endif // CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_ 77 #endif // CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698