Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: cc/trees/layer_tree_impl.cc

Issue 2827163005: Remove scroll layer ids from scrollbar layers (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_impl.h" 5 #include "cc/trees/layer_tree_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1713 matching lines...) Expand 10 before | Expand all | Expand 10 after
1724 if (!scroll_element_id) 1724 if (!scroll_element_id)
1725 return; 1725 return;
1726 1726
1727 element_id_to_scrollbar_layer_ids_.insert( 1727 element_id_to_scrollbar_layer_ids_.insert(
1728 std::pair<ElementId, int>(scroll_element_id, scrollbar_layer->id())); 1728 std::pair<ElementId, int>(scroll_element_id, scrollbar_layer->id()));
1729 if (IsActiveTree() && scrollbar_layer->is_overlay_scrollbar()) { 1729 if (IsActiveTree() && scrollbar_layer->is_overlay_scrollbar()) {
1730 layer_tree_host_impl_->RegisterScrollbarAnimationController( 1730 layer_tree_host_impl_->RegisterScrollbarAnimationController(
1731 scroll_element_id); 1731 scroll_element_id);
1732 } 1732 }
1733 1733
1734 DidUpdateScrollState(scrollbar_layer->ScrollLayerId()); 1734 // TODO(pdr): Refactor DidUpdateScrollState to use ElementIds instead of
1735 // layer ids and remove this use of LayerIdByElementId.
1736 DidUpdateScrollState(LayerIdByElementId(scroll_element_id));
1735 } 1737 }
1736 1738
1737 void LayerTreeImpl::UnregisterScrollbar( 1739 void LayerTreeImpl::UnregisterScrollbar(
1738 ScrollbarLayerImplBase* scrollbar_layer) { 1740 ScrollbarLayerImplBase* scrollbar_layer) {
1739 ElementId scroll_element_id = scrollbar_layer->scroll_element_id(); 1741 ElementId scroll_element_id = scrollbar_layer->scroll_element_id();
1740 if (!scroll_element_id) 1742 if (!scroll_element_id)
1741 return; 1743 return;
1742 1744
1743 auto scrollbar_range = 1745 auto scrollbar_range =
1744 element_id_to_scrollbar_layer_ids_.equal_range(scroll_element_id); 1746 element_id_to_scrollbar_layer_ids_.equal_range(scroll_element_id);
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
2184 2186
2185 void LayerTreeImpl::ResetAllChangeTracking() { 2187 void LayerTreeImpl::ResetAllChangeTracking() {
2186 layers_that_should_push_properties_.clear(); 2188 layers_that_should_push_properties_.clear();
2187 // Iterate over all layers, including masks. 2189 // Iterate over all layers, including masks.
2188 for (auto& layer : *layers_) 2190 for (auto& layer : *layers_)
2189 layer->ResetChangeTracking(); 2191 layer->ResetChangeTracking();
2190 property_trees_.ResetAllChangeTracking(); 2192 property_trees_.ResetAllChangeTracking();
2191 } 2193 }
2192 2194
2193 } // namespace cc 2195 } // namespace cc
OLDNEW
« cc/layers/scrollbar_layer_impl_base.cc ('K') | « cc/trees/layer_tree_host_unittest_damage.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698