Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2827143002: [WASM SIMD] Remove opcodes that are slow on some platforms. (Closed)

Created:
3 years, 8 months ago by bbudge
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[WASM SIMD] Remove opcodes that are slow on some platforms. These can be synthesized from existing operations and scheduled for better performance than if we have to generate blocks of instructions that take many cycles to complete. - Remove F32x4RecipRefine, F32x4RecipSqrtRefine. Clients are better off synthesizing these from splats, multiplies and adds. - Remove F32x4Div, F32x4Sqrt, F32x4MinNum, F32x4MaxNum. Clients are better off synthesizing these or using the reciprocal approximations, possibly with a refinement step. LOG=N BUG=v8:6020 Review-Url: https://codereview.chromium.org/2827143002 Cr-Commit-Position: refs/heads/master@{#44784} Committed: https://chromium.googlesource.com/v8/v8/+/dddfcfd0a965199bdc41954d88f6e57e6cae17e1

Patch Set 1 #

Patch Set 2 : Remove stray tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -165 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +2 lines, -12 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/simd-scalar-lowering.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/wasm/wasm-opcodes.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 3 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
bbudge
Benedikt for compiler Dusan for MIPS Aseem for simd-scalar-lowering
3 years, 8 months ago (2017-04-19 21:10:52 UTC) #9
dusan.simicic
LGTM
3 years, 8 months ago (2017-04-20 10:31:32 UTC) #13
aseemgarg
lgtm
3 years, 8 months ago (2017-04-20 22:37:13 UTC) #14
bbudge
+Mircea for compiler
3 years, 8 months ago (2017-04-21 20:36:47 UTC) #16
Mircea Trofin
On 2017/04/21 20:36:47, bbudge wrote: > +Mircea for compiler lgtm
3 years, 8 months ago (2017-04-21 21:02:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827143002/20001
3 years, 8 months ago (2017-04-21 21:03:54 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 21:34:54 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/dddfcfd0a965199bdc41954d88f6e57e6ca...

Powered by Google App Engine
This is Rietveld 408576698