Landing Recent QUIC changes until Mon Apr 17 2017

Landing Recent QUIC changes until Mon Apr 17 2017

Flip QUIC flags, and remove deprecated flags that were missed.
https://codereview.chromium.org/2821263003/


Move quic_flags.h from net/quic/core to net/quic/platform and split into api and impl.

Merge internal change: 153366836
https://codereview.chromium.org/2820423002/


Deprecate FLAGS_quic_reloadable_flag_fix_quic_callback_crash

Merge internal change: 153341928
https://codereview.chromium.org/2825833002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37

Merge internal change: 153233259
https://codereview.chromium.org/2827503003/


In QUIC version >= 38, enables random padding of size [1, 256]

Protected by FLAGS_quic_reloadable_flag_quic_enable_random_padding.

Merge internal change: 153198827
https://codereview.chromium.org/2820263005/


Tweak BBR tests with the keep sending flag enabled to consistently pass unit tests.

n/a (Fix flaky test)

Merge internal change: 153196381
https://codereview.chromium.org/2820413002/


Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const GetCryptoStream(). Make QuicSession::IsEncryptionEstablished and IsCryptoHandshakeConfirmed constant. Not protected.

Merge internal change: 153185176
https://codereview.chromium.org/2823223003/


Change a QUIC_DLOG to a QUIC_DVLOG.

This line was printing a tremendous amount in test logs and causing erroneous
test failures due to output size.

Merge internal change: 153109322
https://codereview.chromium.org/2823303002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3

Merge internal change: 153101554
https://codereview.chromium.org/2822023005/


deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support for QUIC v34.

Merge internal change: 153091520
https://codereview.chromium.org/2823293002/


Let QUIC be able to add random padding of [1,256] bytes after fin is consumed for a stream. Random paddings have the lowest priority to send. Not used in prod yet.

Merge internal change: 153055858
https://codereview.chromium.org/2828543002/


Uniquify QuicCryptoServerConfig::SetEphemeralKeySource

Modify QuicCryptoServerConfig::SetEphemeralKeySource to take its argument by
unique_ptr, which makes it obvious how ownership of the argument is transferred.

Bare pointer -> unique_ptr in QUIC startup code.  No functional
change, not flag-protected.

Merge internal change: 152970365
https://codereview.chromium.org/2825493004/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled position because it never worked that well.

Merge internal change: 152853633
https://codereview.chromium.org/2828523003/


deprecate FLAGS_quic_reloadable_flag_quic_large_ifw_options

Merge internal change: 152840111
https://codereview.chromium.org/2825523003/


Add flag counter for FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption

Merge internal change: 152840108
https://codereview.chromium.org/2823283002/


Improve QUIC flow-control commentary and variable-names.

While debugging, I found the current commentary and variable names to
be a bit confusing.  Made some tiny cosmetic improvements.

Merge internal change: 152816981
https://codereview.chromium.org/2824773005/


Base QUIC BBR's CWND on SRTT instead of min_rtt.  Protected by FLAGS_quic_reloadable_flag_quic_base_cwnd_on_srtt.

Also fixes test flakiness with FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate by limiting the CWND in low gain mode and pacing based on max_bw in high gain mode.

Merge internal change: 152772923
https://codereview.chromium.org/2823083004/


Continue sending at the max bandwidth measured in the last two rounds for another SRTT.  Protected by FLAGS_quic_reloadable_flags_quic_bbr_keep_sending_at_recent_rate.

Merge internal change: 152764149
https://codereview.chromium.org/2825093002/


Deprecate FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.

Merge internal change: 152732968
https://codereview.chromium.org/2825773002/

Review-Url: https://codereview.chromium.org/2825083003
Cr-Commit-Position: refs/heads/master@{#465461}
Committed: https://chromium.googlesource.com/chromium/src/+/fc6809b6348e520d3ce533d5765324adb8de3918

[Ryan Hamilton, 2017-04-18 18:56:49]

Description was changed from

==========
Flip QUIC flags, and remove deprecated flags that were missed.

Move quic_flags.h from net/quic/core to net/quic/platform and split into api and
impl.

Merge internal change: 153366836

Deprecate FLAGS_quic_reloadable_flag_fix_quic_callback_crash

Merge internal change: 153341928

deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37

Merge internal change: 153233259

In QUIC version >= 38, enables random padding of size [1, 256]

Protected by FLAGS_quic_reloadable_flag_quic_enable_random_padding.

Merge internal change: 153198827

Tweak BBR tests with the keep sending flag enabled to consistently pass unit
tests.

n/a (Fix flaky test)

Merge internal change: 153196381

Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const
GetCryptoStream(). Make QuicSession::IsEncryptionEstablished and
IsCryptoHandshakeConfirmed constant. Not protected.

Merge internal change: 153185176

Change a QUIC_DLOG to a QUIC_DVLOG.

This line was printing a tremendous amount in test logs and causing erroneous
test failures due to output size.

Merge internal change: 153109322

deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3

Merge internal change: 153101554

deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support
for QUIC v34.

Merge internal change: 153091520

Let QUIC be able to add random padding of [1,256] bytes after fin is consumed
for a stream. Random paddings have the lowest priority to send. Not used in prod
yet.

Merge internal change: 153055858

Uniquify QuicCryptoServerConfig::SetEphemeralKeySource

Modify QuicCryptoServerConfig::SetEphemeralKeySource to take its argument by
unique_ptr, which makes it obvious how ownership of the argument is transferred.

Bare pointer -> unique_ptr in QUIC startup code.  No functional
change, not flag-protected.

Merge internal change: 152970365

Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled
position because it never worked that well.

Merge internal change: 152853633

deprecate FLAGS_quic_reloadable_flag_quic_large_ifw_options

Merge internal change: 152840111

Add flag counter for FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption

Merge internal change: 152840108

Improve QUIC flow-control commentary and variable-names.

While debugging, I found the current commentary and variable names to
be a bit confusing.  Made some tiny cosmetic improvements.

Merge internal change: 152816981

Base QUIC BBR's CWND on SRTT instead of min_rtt.  Protected by
FLAGS_quic_reloadable_flag_quic_base_cwnd_on_srtt.

Also fixes test flakiness with
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate by limiting the
CWND in low gain mode and pacing based on max_bw in high gain mode.

Merge internal change: 152772923

Continue sending at the max bandwidth measured in the last two rounds for
another SRTT.  Protected by
FLAGS_quic_reloadable_flags_quic_bbr_keep_sending_at_recent_rate.

Merge internal change: 152764149

Deprecate FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.

Merge internal change: 152732968

BUG=
==========

to

==========
Landing Recent QUIC changes until Mon Apr 17 2017

Flip QUIC flags, and remove deprecated flags that were missed.

Move quic_flags.h from net/quic/core to net/quic/platform and split into api and
impl.

Merge internal change: 153366836

Deprecate FLAGS_quic_reloadable_flag_fix_quic_callback_crash

Merge internal change: 153341928

deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37

Merge internal change: 153233259

In QUIC version >= 38, enables random padding of size [1, 256]

Protected by FLAGS_quic_reloadable_flag_quic_enable_random_padding.

Merge internal change: 153198827

Tweak BBR tests with the keep sending flag enabled to consistently pass unit
tests.

n/a (Fix flaky test)

Merge internal change: 153196381

Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const
GetCryptoStream(). Make QuicSession::IsEncryptionEstablished and
IsCryptoHandshakeConfirmed constant. Not protected.

Merge internal change: 153185176

Change a QUIC_DLOG to a QUIC_DVLOG.

This line was printing a tremendous amount in test logs and causing erroneous
test failures due to output size.

Merge internal change: 153109322

deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3

Merge internal change: 153101554

deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support
for QUIC v34.

Merge internal change: 153091520

Let QUIC be able to add random padding of [1,256] bytes after fin is consumed
for a stream. Random paddings have the lowest priority to send. Not used in prod
yet.

Merge internal change: 153055858

Uniquify QuicCryptoServerConfig::SetEphemeralKeySource

Modify QuicCryptoServerConfig::SetEphemeralKeySource to take its argument by
unique_ptr, which makes it obvious how ownership of the argument is transferred.

Bare pointer -> unique_ptr in QUIC startup code.  No functional
change, not flag-protected.

Merge internal change: 152970365

Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled
position because it never worked that well.

Merge internal change: 152853633

deprecate FLAGS_quic_reloadable_flag_quic_large_ifw_options

Merge internal change: 152840111

Add flag counter for FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption

Merge internal change: 152840108

Improve QUIC flow-control commentary and variable-names.

While debugging, I found the current commentary and variable names to
be a bit confusing.  Made some tiny cosmetic improvements.

Merge internal change: 152816981

Base QUIC BBR's CWND on SRTT instead of min_rtt.  Protected by
FLAGS_quic_reloadable_flag_quic_base_cwnd_on_srtt.

Also fixes test flakiness with
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate by limiting the
CWND in low gain mode and pacing based on max_bw in high gain mode.

Merge internal change: 152772923

Continue sending at the max bandwidth measured in the last two rounds for
another SRTT.  Protected by
FLAGS_quic_reloadable_flags_quic_bbr_keep_sending_at_recent_rate.

Merge internal change: 152764149

Deprecate FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.

Merge internal change: 152732968

BUG=
==========

[Ryan Hamilton, 2017-04-18 18:58:40]

Description was changed from

==========
Landing Recent QUIC changes until Mon Apr 17 2017

Flip QUIC flags, and remove deprecated flags that were missed.

Move quic_flags.h from net/quic/core to net/quic/platform and split into api and
impl.

Merge internal change: 153366836

Deprecate FLAGS_quic_reloadable_flag_fix_quic_callback_crash

Merge internal change: 153341928

deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37

Merge internal change: 153233259

In QUIC version >= 38, enables random padding of size [1, 256]

Protected by FLAGS_quic_reloadable_flag_quic_enable_random_padding.

Merge internal change: 153198827

Tweak BBR tests with the keep sending flag enabled to consistently pass unit
tests.

n/a (Fix flaky test)

Merge internal change: 153196381

Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const
GetCryptoStream(). Make QuicSession::IsEncryptionEstablished and
IsCryptoHandshakeConfirmed constant. Not protected.

Merge internal change: 153185176

Change a QUIC_DLOG to a QUIC_DVLOG.

This line was printing a tremendous amount in test logs and causing erroneous
test failures due to output size.

Merge internal change: 153109322

deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3

Merge internal change: 153101554

deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support
for QUIC v34.

Merge internal change: 153091520

Let QUIC be able to add random padding of [1,256] bytes after fin is consumed
for a stream. Random paddings have the lowest priority to send. Not used in prod
yet.

Merge internal change: 153055858

Uniquify QuicCryptoServerConfig::SetEphemeralKeySource

Modify QuicCryptoServerConfig::SetEphemeralKeySource to take its argument by
unique_ptr, which makes it obvious how ownership of the argument is transferred.

Bare pointer -> unique_ptr in QUIC startup code.  No functional
change, not flag-protected.

Merge internal change: 152970365

Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled
position because it never worked that well.

Merge internal change: 152853633

deprecate FLAGS_quic_reloadable_flag_quic_large_ifw_options

Merge internal change: 152840111

Add flag counter for FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption

Merge internal change: 152840108

Improve QUIC flow-control commentary and variable-names.

While debugging, I found the current commentary and variable names to
be a bit confusing.  Made some tiny cosmetic improvements.

Merge internal change: 152816981

Base QUIC BBR's CWND on SRTT instead of min_rtt.  Protected by
FLAGS_quic_reloadable_flag_quic_base_cwnd_on_srtt.

Also fixes test flakiness with
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate by limiting the
CWND in low gain mode and pacing based on max_bw in high gain mode.

Merge internal change: 152772923

Continue sending at the max bandwidth measured in the last two rounds for
another SRTT.  Protected by
FLAGS_quic_reloadable_flags_quic_bbr_keep_sending_at_recent_rate.

Merge internal change: 152764149

Deprecate FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.

Merge internal change: 152732968

BUG=
==========

to

==========
Landing Recent QUIC changes until Mon Apr 17 2017

Flip QUIC flags, and remove deprecated flags that were missed.

Move quic_flags.h from net/quic/core to net/quic/platform and split into api and
impl.

Merge internal change: 153366836
https://codereview.chromium.org/2820423002/


Deprecate FLAGS_quic_reloadable_flag_fix_quic_callback_crash

Merge internal change: 153341928
https://codereview.chromium.org/2825833002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37

Merge internal change: 153233259
https://codereview.chromium.org/2827503003/


In QUIC version >= 38, enables random padding of size [1, 256]

Protected by FLAGS_quic_reloadable_flag_quic_enable_random_padding.

Merge internal change: 153198827
https://codereview.chromium.org/2820263005/


Tweak BBR tests with the keep sending flag enabled to consistently pass unit
tests.

n/a (Fix flaky test)

Merge internal change: 153196381
https://codereview.chromium.org/2820413002/


Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const
GetCryptoStream(). Make QuicSession::IsEncryptionEstablished and
IsCryptoHandshakeConfirmed constant. Not protected.

Merge internal change: 153185176
https://codereview.chromium.org/2823223003/


Change a QUIC_DLOG to a QUIC_DVLOG.

This line was printing a tremendous amount in test logs and causing erroneous
test failures due to output size.

Merge internal change: 153109322
https://codereview.chromium.org/2823303002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3

Merge internal change: 153101554
https://codereview.chromium.org/2822023005/


deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support
for QUIC v34.

Merge internal change: 153091520
https://codereview.chromium.org/2823293002/


Let QUIC be able to add random padding of [1,256] bytes after fin is consumed
for a stream. Random paddings have the lowest priority to send. Not used in prod
yet.

Merge internal change: 153055858
https://codereview.chromium.org/2828543002/


Uniquify QuicCryptoServerConfig::SetEphemeralKeySource

Modify QuicCryptoServerConfig::SetEphemeralKeySource to take its argument by
unique_ptr, which makes it obvious how ownership of the argument is transferred.

Bare pointer -> unique_ptr in QUIC startup code.  No functional
change, not flag-protected.

Merge internal change: 152970365
https://codereview.chromium.org/2825493004/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled
position because it never worked that well.

Merge internal change: 152853633
https://codereview.chromium.org/2828523003/


deprecate FLAGS_quic_reloadable_flag_quic_large_ifw_options

Merge internal change: 152840111
https://codereview.chromium.org/2825523003/


Add flag counter for FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption

Merge internal change: 152840108
https://codereview.chromium.org/2823283002/


Improve QUIC flow-control commentary and variable-names.

While debugging, I found the current commentary and variable names to
be a bit confusing.  Made some tiny cosmetic improvements.

Merge internal change: 152816981
https://codereview.chromium.org/2824773005/


Base QUIC BBR's CWND on SRTT instead of min_rtt.  Protected by
FLAGS_quic_reloadable_flag_quic_base_cwnd_on_srtt.

Also fixes test flakiness with
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate by limiting the
CWND in low gain mode and pacing based on max_bw in high gain mode.

Merge internal change: 152772923
https://codereview.chromium.org/2823083004/


Continue sending at the max bandwidth measured in the last two rounds for
another SRTT.  Protected by
FLAGS_quic_reloadable_flags_quic_bbr_keep_sending_at_recent_rate.

Merge internal change: 152764149
https://codereview.chromium.org/2825093002/


Deprecate FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.

Merge internal change: 152732968
https://codereview.chromium.org/2825773002/
==========

[Ryan Hamilton, 2017-04-18 18:59:05]

Description was changed from

==========
Landing Recent QUIC changes until Mon Apr 17 2017

Flip QUIC flags, and remove deprecated flags that were missed.

Move quic_flags.h from net/quic/core to net/quic/platform and split into api and
impl.

Merge internal change: 153366836
https://codereview.chromium.org/2820423002/


Deprecate FLAGS_quic_reloadable_flag_fix_quic_callback_crash

Merge internal change: 153341928
https://codereview.chromium.org/2825833002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37

Merge internal change: 153233259
https://codereview.chromium.org/2827503003/


In QUIC version >= 38, enables random padding of size [1, 256]

Protected by FLAGS_quic_reloadable_flag_quic_enable_random_padding.

Merge internal change: 153198827
https://codereview.chromium.org/2820263005/


Tweak BBR tests with the keep sending flag enabled to consistently pass unit
tests.

n/a (Fix flaky test)

Merge internal change: 153196381
https://codereview.chromium.org/2820413002/


Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const
GetCryptoStream(). Make QuicSession::IsEncryptionEstablished and
IsCryptoHandshakeConfirmed constant. Not protected.

Merge internal change: 153185176
https://codereview.chromium.org/2823223003/


Change a QUIC_DLOG to a QUIC_DVLOG.

This line was printing a tremendous amount in test logs and causing erroneous
test failures due to output size.

Merge internal change: 153109322
https://codereview.chromium.org/2823303002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3

Merge internal change: 153101554
https://codereview.chromium.org/2822023005/


deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support
for QUIC v34.

Merge internal change: 153091520
https://codereview.chromium.org/2823293002/


Let QUIC be able to add random padding of [1,256] bytes after fin is consumed
for a stream. Random paddings have the lowest priority to send. Not used in prod
yet.

Merge internal change: 153055858
https://codereview.chromium.org/2828543002/


Uniquify QuicCryptoServerConfig::SetEphemeralKeySource

Modify QuicCryptoServerConfig::SetEphemeralKeySource to take its argument by
unique_ptr, which makes it obvious how ownership of the argument is transferred.

Bare pointer -> unique_ptr in QUIC startup code.  No functional
change, not flag-protected.

Merge internal change: 152970365
https://codereview.chromium.org/2825493004/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled
position because it never worked that well.

Merge internal change: 152853633
https://codereview.chromium.org/2828523003/


deprecate FLAGS_quic_reloadable_flag_quic_large_ifw_options

Merge internal change: 152840111
https://codereview.chromium.org/2825523003/


Add flag counter for FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption

Merge internal change: 152840108
https://codereview.chromium.org/2823283002/


Improve QUIC flow-control commentary and variable-names.

While debugging, I found the current commentary and variable names to
be a bit confusing.  Made some tiny cosmetic improvements.

Merge internal change: 152816981
https://codereview.chromium.org/2824773005/


Base QUIC BBR's CWND on SRTT instead of min_rtt.  Protected by
FLAGS_quic_reloadable_flag_quic_base_cwnd_on_srtt.

Also fixes test flakiness with
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate by limiting the
CWND in low gain mode and pacing based on max_bw in high gain mode.

Merge internal change: 152772923
https://codereview.chromium.org/2823083004/


Continue sending at the max bandwidth measured in the last two rounds for
another SRTT.  Protected by
FLAGS_quic_reloadable_flags_quic_bbr_keep_sending_at_recent_rate.

Merge internal change: 152764149
https://codereview.chromium.org/2825093002/


Deprecate FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.

Merge internal change: 152732968
https://codereview.chromium.org/2825773002/
==========

to

==========
Landing Recent QUIC changes until Mon Apr 17 2017

Flip QUIC flags, and remove deprecated flags that were missed.
https://codereview.chromium.org/2821263003/


Move quic_flags.h from net/quic/core to net/quic/platform and split into api and
impl.

Merge internal change: 153366836
https://codereview.chromium.org/2820423002/


Deprecate FLAGS_quic_reloadable_flag_fix_quic_callback_crash

Merge internal change: 153341928
https://codereview.chromium.org/2825833002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37

Merge internal change: 153233259
https://codereview.chromium.org/2827503003/


In QUIC version >= 38, enables random padding of size [1, 256]

Protected by FLAGS_quic_reloadable_flag_quic_enable_random_padding.

Merge internal change: 153198827
https://codereview.chromium.org/2820263005/


Tweak BBR tests with the keep sending flag enabled to consistently pass unit
tests.

n/a (Fix flaky test)

Merge internal change: 153196381
https://codereview.chromium.org/2820413002/


Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const
GetCryptoStream(). Make QuicSession::IsEncryptionEstablished and
IsCryptoHandshakeConfirmed constant. Not protected.

Merge internal change: 153185176
https://codereview.chromium.org/2823223003/


Change a QUIC_DLOG to a QUIC_DVLOG.

This line was printing a tremendous amount in test logs and causing erroneous
test failures due to output size.

Merge internal change: 153109322
https://codereview.chromium.org/2823303002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3

Merge internal change: 153101554
https://codereview.chromium.org/2822023005/


deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support
for QUIC v34.

Merge internal change: 153091520
https://codereview.chromium.org/2823293002/


Let QUIC be able to add random padding of [1,256] bytes after fin is consumed
for a stream. Random paddings have the lowest priority to send. Not used in prod
yet.

Merge internal change: 153055858
https://codereview.chromium.org/2828543002/


Uniquify QuicCryptoServerConfig::SetEphemeralKeySource

Modify QuicCryptoServerConfig::SetEphemeralKeySource to take its argument by
unique_ptr, which makes it obvious how ownership of the argument is transferred.

Bare pointer -> unique_ptr in QUIC startup code.  No functional
change, not flag-protected.

Merge internal change: 152970365
https://codereview.chromium.org/2825493004/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled
position because it never worked that well.

Merge internal change: 152853633
https://codereview.chromium.org/2828523003/


deprecate FLAGS_quic_reloadable_flag_quic_large_ifw_options

Merge internal change: 152840111
https://codereview.chromium.org/2825523003/


Add flag counter for FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption

Merge internal change: 152840108
https://codereview.chromium.org/2823283002/


Improve QUIC flow-control commentary and variable-names.

While debugging, I found the current commentary and variable names to
be a bit confusing.  Made some tiny cosmetic improvements.

Merge internal change: 152816981
https://codereview.chromium.org/2824773005/


Base QUIC BBR's CWND on SRTT instead of min_rtt.  Protected by
FLAGS_quic_reloadable_flag_quic_base_cwnd_on_srtt.

Also fixes test flakiness with
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate by limiting the
CWND in low gain mode and pacing based on max_bw in high gain mode.

Merge internal change: 152772923
https://codereview.chromium.org/2823083004/


Continue sending at the max bandwidth measured in the last two rounds for
another SRTT.  Protected by
FLAGS_quic_reloadable_flags_quic_bbr_keep_sending_at_recent_rate.

Merge internal change: 152764149
https://codereview.chromium.org/2825093002/


Deprecate FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.

Merge internal change: 152732968
https://codereview.chromium.org/2825773002/
==========

[Ryan Hamilton, 2017-04-18 19:02:03]

rch@chromium.org changed reviewers:
+ zhongyi@chromium.org

[Ryan Hamilton, 2017-04-18 22:48:08]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 22:48:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2017-04-18 22:52:58]

lgtm

[commit-bot: I haz the power, 2017-04-19 00:44:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 00:44:51]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-04-19 01:29:03]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2017-04-19 01:29:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 01:37:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492565343086530,
"parent_rev": "9a92b780885a1276a8e19758ddef50acfa87f2cc", "commit_rev":
"fc6809b6348e520d3ce533d5765324adb8de3918"}

[commit-bot: I haz the power, 2017-04-19 01:37:15]

Description was changed from

==========
Landing Recent QUIC changes until Mon Apr 17 2017

Flip QUIC flags, and remove deprecated flags that were missed.
https://codereview.chromium.org/2821263003/


Move quic_flags.h from net/quic/core to net/quic/platform and split into api and
impl.

Merge internal change: 153366836
https://codereview.chromium.org/2820423002/


Deprecate FLAGS_quic_reloadable_flag_fix_quic_callback_crash

Merge internal change: 153341928
https://codereview.chromium.org/2825833002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37

Merge internal change: 153233259
https://codereview.chromium.org/2827503003/


In QUIC version >= 38, enables random padding of size [1, 256]

Protected by FLAGS_quic_reloadable_flag_quic_enable_random_padding.

Merge internal change: 153198827
https://codereview.chromium.org/2820263005/


Tweak BBR tests with the keep sending flag enabled to consistently pass unit
tests.

n/a (Fix flaky test)

Merge internal change: 153196381
https://codereview.chromium.org/2820413002/


Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const
GetCryptoStream(). Make QuicSession::IsEncryptionEstablished and
IsCryptoHandshakeConfirmed constant. Not protected.

Merge internal change: 153185176
https://codereview.chromium.org/2823223003/


Change a QUIC_DLOG to a QUIC_DVLOG.

This line was printing a tremendous amount in test logs and causing erroneous
test failures due to output size.

Merge internal change: 153109322
https://codereview.chromium.org/2823303002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3

Merge internal change: 153101554
https://codereview.chromium.org/2822023005/


deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support
for QUIC v34.

Merge internal change: 153091520
https://codereview.chromium.org/2823293002/


Let QUIC be able to add random padding of [1,256] bytes after fin is consumed
for a stream. Random paddings have the lowest priority to send. Not used in prod
yet.

Merge internal change: 153055858
https://codereview.chromium.org/2828543002/


Uniquify QuicCryptoServerConfig::SetEphemeralKeySource

Modify QuicCryptoServerConfig::SetEphemeralKeySource to take its argument by
unique_ptr, which makes it obvious how ownership of the argument is transferred.

Bare pointer -> unique_ptr in QUIC startup code.  No functional
change, not flag-protected.

Merge internal change: 152970365
https://codereview.chromium.org/2825493004/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled
position because it never worked that well.

Merge internal change: 152853633
https://codereview.chromium.org/2828523003/


deprecate FLAGS_quic_reloadable_flag_quic_large_ifw_options

Merge internal change: 152840111
https://codereview.chromium.org/2825523003/


Add flag counter for FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption

Merge internal change: 152840108
https://codereview.chromium.org/2823283002/


Improve QUIC flow-control commentary and variable-names.

While debugging, I found the current commentary and variable names to
be a bit confusing.  Made some tiny cosmetic improvements.

Merge internal change: 152816981
https://codereview.chromium.org/2824773005/


Base QUIC BBR's CWND on SRTT instead of min_rtt.  Protected by
FLAGS_quic_reloadable_flag_quic_base_cwnd_on_srtt.

Also fixes test flakiness with
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate by limiting the
CWND in low gain mode and pacing based on max_bw in high gain mode.

Merge internal change: 152772923
https://codereview.chromium.org/2823083004/


Continue sending at the max bandwidth measured in the last two rounds for
another SRTT.  Protected by
FLAGS_quic_reloadable_flags_quic_bbr_keep_sending_at_recent_rate.

Merge internal change: 152764149
https://codereview.chromium.org/2825093002/


Deprecate FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.

Merge internal change: 152732968
https://codereview.chromium.org/2825773002/
==========

to

==========
Landing Recent QUIC changes until Mon Apr 17 2017

Flip QUIC flags, and remove deprecated flags that were missed.
https://codereview.chromium.org/2821263003/


Move quic_flags.h from net/quic/core to net/quic/platform and split into api and
impl.

Merge internal change: 153366836
https://codereview.chromium.org/2820423002/


Deprecate FLAGS_quic_reloadable_flag_fix_quic_callback_crash

Merge internal change: 153341928
https://codereview.chromium.org/2825833002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37

Merge internal change: 153233259
https://codereview.chromium.org/2827503003/


In QUIC version >= 38, enables random padding of size [1, 256]

Protected by FLAGS_quic_reloadable_flag_quic_enable_random_padding.

Merge internal change: 153198827
https://codereview.chromium.org/2820263005/


Tweak BBR tests with the keep sending flag enabled to consistently pass unit
tests.

n/a (Fix flaky test)

Merge internal change: 153196381
https://codereview.chromium.org/2820413002/


Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const
GetCryptoStream(). Make QuicSession::IsEncryptionEstablished and
IsCryptoHandshakeConfirmed constant. Not protected.

Merge internal change: 153185176
https://codereview.chromium.org/2823223003/


Change a QUIC_DLOG to a QUIC_DVLOG.

This line was printing a tremendous amount in test logs and causing erroneous
test failures due to output size.

Merge internal change: 153109322
https://codereview.chromium.org/2823303002/


deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3

Merge internal change: 153101554
https://codereview.chromium.org/2822023005/


deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support
for QUIC v34.

Merge internal change: 153091520
https://codereview.chromium.org/2823293002/


Let QUIC be able to add random padding of [1,256] bytes after fin is consumed
for a stream. Random paddings have the lowest priority to send. Not used in prod
yet.

Merge internal change: 153055858
https://codereview.chromium.org/2828543002/


Uniquify QuicCryptoServerConfig::SetEphemeralKeySource

Modify QuicCryptoServerConfig::SetEphemeralKeySource to take its argument by
unique_ptr, which makes it obvious how ownership of the argument is transferred.

Bare pointer -> unique_ptr in QUIC startup code.  No functional
change, not flag-protected.

Merge internal change: 152970365
https://codereview.chromium.org/2825493004/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled
position because it never worked that well.

Merge internal change: 152853633
https://codereview.chromium.org/2828523003/


deprecate FLAGS_quic_reloadable_flag_quic_large_ifw_options

Merge internal change: 152840111
https://codereview.chromium.org/2825523003/


Add flag counter for FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption

Merge internal change: 152840108
https://codereview.chromium.org/2823283002/


Improve QUIC flow-control commentary and variable-names.

While debugging, I found the current commentary and variable names to
be a bit confusing.  Made some tiny cosmetic improvements.

Merge internal change: 152816981
https://codereview.chromium.org/2824773005/


Base QUIC BBR's CWND on SRTT instead of min_rtt.  Protected by
FLAGS_quic_reloadable_flag_quic_base_cwnd_on_srtt.

Also fixes test flakiness with
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate by limiting the
CWND in low gain mode and pacing based on max_bw in high gain mode.

Merge internal change: 152772923
https://codereview.chromium.org/2823083004/


Continue sending at the max bandwidth measured in the last two rounds for
another SRTT.  Protected by
FLAGS_quic_reloadable_flags_quic_bbr_keep_sending_at_recent_rate.

Merge internal change: 152764149
https://codereview.chromium.org/2825093002/


Deprecate FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.

Merge internal change: 152732968
https://codereview.chromium.org/2825773002/

Review-Url: https://codereview.chromium.org/2825083003
Cr-Commit-Position: refs/heads/master@{#465461}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc6809b6348e520d3ce533d57653...
==========

[commit-bot: I haz the power, 2017-04-19 01:37:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fc6809b6348e520d3ce533d57653...