Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2823223003: Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const GetCryptoStream(). M… (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename QuicSession::GetCryptoStream() to GetMutableCryptoStream(). Add a const GetCryptoStream(). Make QuicSession::IsEncryptionEstablished and IsCryptoHandshakeConfirmed constant. Not protected. Merge internal change: 153185176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -66 lines) Patch
M net/quic/chromium/quic_chromium_client_session.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_server_session_base.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/core/quic_server_session_base.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_session.h View 2 chunks +6 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 11 chunks +17 lines, -11 lines 0 comments Download
M net/quic/quartc/quartc_session.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quartc/quartc_session.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/quartc/quartc_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 6 chunks +20 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_session.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Ryan Hamilton
3 years, 8 months ago (2017-04-18 19:01:23 UTC) #2
Zhongyi Shi
3 years, 8 months ago (2017-04-18 21:42:12 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698