Issue 2825493004: Uniquify QuicCryptoServerConfig::SetEphemeralKeySource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2825493004: Uniquify QuicCryptoServerConfig::SetEphemeralKeySource (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton

Modified:
3 years, 8 months ago

Reviewers:
Zhongyi Shi

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Uniquify QuicCryptoServerConfig::SetEphemeralKeySource Modify QuicCryptoServerConfig::SetEphemeralKeySource to take its argument by unique_ptr, which makes it obvious how ownership of the argument is transferred. Bare pointer -> unique_ptr in QUIC startup code. No functional change, not flag-protected. Merge internal change: 152970365

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	net/quic/core/crypto/quic_crypto_server_config.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	net/quic/core/crypto/quic_crypto_server_config.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 2828523003 Patch 1

Dependent Patchsets:

Issue 2828543002 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages