Issue 2823083004: Base QUIC BBR's CWND on SRTT instead of min_rtt. Protected by FLAGS_quic_reloadable_flag_quic_base…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2823083004: Base QUIC BBR's CWND on SRTT instead of min_rtt. Protected by FLAGS_quic_reloadable_flag_quic_base… (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton

Modified:
3 years, 8 months ago

Reviewers:
Zhongyi Shi

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Base QUIC BBR's CWND on SRTT instead of min_rtt. Protected by FLAGS_quic_reloadable_flag_quic_base_cwnd_on_srtt. Also fixes test flakiness with FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate by limiting the CWND in low gain mode and pacing based on max_bw in high gain mode. Merge internal change: 152772923

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -4 lines)			Patch
M	net/quic/core/congestion_control/bbr_sender.cc	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	net/quic/core/congestion_control/bbr_sender_test.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	net/quic/core/quic_flags_list.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2825093002 Patch 1

Dependent Patchsets:

Issue 2824773005 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages