Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2827503003: deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37 (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37 Merge internal change: 153233259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M net/quic/core/quic_version_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_version_manager.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/core/quic_version_manager_test.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M net/quic/core/quic_versions.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M net/quic/core/quic_versions_test.cc View 2 chunks +28 lines, -7 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2820263005 Patch 1

Dependent Patchsets:

Issue 2825833002 Patch 1

Messages

Total messages: 4 (1 generated)
Ryan Hamilton
3 years, 8 months ago (2017-04-18 19:01:32 UTC) #2
Zhongyi Shi
I think you can remove the flag from quic_flags_list.h as well?
3 years, 8 months ago (2017-04-18 21:49:56 UTC) #3
Zhongyi Shi
3 years, 8 months ago (2017-04-18 21:51:16 UTC) #4 
On 2017/04/18 21:49:56, Zhongyi Shi wrote:
> I think you can remove the flag from quic_flags_list.h as well?

Ah, okay, it's removed in the flag flipping CL.

lgtm

Powered by Google App Engine
This is Rietveld 408576698