Media Controls: move timeline related code to modules.

Media Controls: move timeline related code to modules.

This is moving the timeline slider code and its metrics helper class. It
is also moving a method out of MediaControls.h that should have happen
in a different CL. Because of headers being reduced, the CL also
requires to add a few headers to implement files.

BUG=662761
R=avayvod@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2820343002
Cr-Commit-Position: refs/heads/master@{#466048}
Committed: https://chromium.googlesource.com/chromium/src/+/322f0d1c2543907fcc64ebcf55845d91c8b7e88b

[mlamouri (slow - plz ping), 2017-04-18 09:55:10]

avayvod@, PTAL at *

jochen@, PTAL at:
- core/html/BUILD.gn
- core/layout/*

[mlamouri (slow - plz ping), 2017-04-18 09:55:16]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 09:55:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-04-18 11:39:51]

lgtm

[commit-bot: I haz the power, 2017-04-18 12:05:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 12:05:15]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-04-19 08:59:55]

avayvod@, gentle ping :)

[mlamouri (slow - plz ping), 2017-04-20 10:19:06]

mlamouri@chromium.org changed reviewers:
+ zqzhang@chromium.org

[mlamouri (slow - plz ping), 2017-04-20 10:19:07]

+zqzhang@, can you PTAL :)

[Zhiqiang Zhang (Slow), 2017-04-20 10:56:34]

lgtm

https://codereview.chromium.org/2820343002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
(right):

https://codereview.chromium.org/2820343002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp:62:
void MediaControlTimelineElement::DefaultEventHandler(Event* event) {
I know this method is old code, but it seems too long to read, especially the
UMA code is everywhere. Maybe we could split it in the future for better
readability.

[whywhat, 2017-04-20 12:45:01]

lgtm

[mlamouri (slow - plz ping), 2017-04-20 14:17:20]

https://codereview.chromium.org/2820343002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
(right):

https://codereview.chromium.org/2820343002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp:62:
void MediaControlTimelineElement::DefaultEventHandler(Event* event) {
On 2017/04/20 at 10:56:34, Zhiqiang Zhang wrote:
> I know this method is old code, but it seems too long to read, especially the
UMA code is everywhere. Maybe we could split it in the future for better
readability.

I agree that this could be improved. Hopefully, we will drop the metrics when we
rewrite the timeline.

[mlamouri (slow - plz ping), 2017-04-20 14:17:22]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2017-04-20 14:17:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 17:25:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492697842074930, "parent_rev":
"b0886512757808f5a6747dbf31b7fb0ada721740", "commit_rev":
"322f0d1c2543907fcc64ebcf55845d91c8b7e88b"}

[commit-bot: I haz the power, 2017-04-20 17:25:47]

Description was changed from

==========
Media Controls: move timeline related code to modules.

This is moving the timeline slider code and its metrics helper class. It
is also moving a method out of MediaControls.h that should have happen
in a different CL. Because of headers being reduced, the CL also
requires to add a few headers to implement files.

BUG=662761
R=avayvod@chromium.org,jochen@chromium.org
==========

to

==========
Media Controls: move timeline related code to modules.

This is moving the timeline slider code and its metrics helper class. It
is also moving a method out of MediaControls.h that should have happen
in a different CL. Because of headers being reduced, the CL also
requires to add a few headers to implement files.

BUG=662761
R=avayvod@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2820343002
Cr-Commit-Position: refs/heads/master@{#466048}
Committed:
https://chromium.googlesource.com/chromium/src/+/322f0d1c2543907fcc64ebcf5584...
==========

[commit-bot: I haz the power, 2017-04-20 17:25:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/322f0d1c2543907fcc64ebcf5584...