Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2820343002: Media Controls: move timeline related code to modules. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
index d761f237a4a66c798583b11414f53dcf78d029ce..562f668dfcf95f355e9054c8fd22fd4631a63c8c 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
@@ -52,6 +52,7 @@ class MediaControlPanelEnclosureElement;
class MediaControlPlayButtonElement;
class MediaControlRemainingTimeDisplayElement;
class MediaControlTextTrackListElement;
+class MediaControlTimelineElement;
class MediaControlToggleClosedCaptionsButtonElement;
class ShadowRoot;
@@ -102,10 +103,6 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
// Return the internal elements, which is used by registering clicking
// EventHandlers from MediaControlsWindowEventListener.
HTMLDivElement* PanelElement() override;
- void BeginScrubbing() override;
- void EndScrubbing() override;
- void UpdateCurrentTimeDisplay() override;
- bool OverflowMenuVisible() override;
// TODO(mlamouri): this method is needed in order to notify the controls that
// the `MediaControlsEnabled` setting has changed.
void OnMediaControlsEnabledChange() override {
@@ -123,11 +120,17 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
void ShowTextTrackAtIndex(unsigned);
void DisableShowingTextTracks();
- // Toggle the overflow menu visibility.
+ // Methods related to the overflow menu.
void ToggleOverflowMenu();
+ bool OverflowMenuVisible();
void ShowOverlayCastButtonIfNeeded();
+ // Methods call by the scrubber.
+ void BeginScrubbing();
+ void EndScrubbing();
+ void UpdateCurrentTimeDisplay();
+
DECLARE_VIRTUAL_TRACE();
private:

Powered by Google App Engine
This is Rietveld 408576698