Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2830653002: Media Controls: move volume slider to modules/. (Closed)

Created:
3 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 8 months ago
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dshwang, dougt+watch_chromium.org, dtseng+watch_chromium.org, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, haraken, jchaffraix+rendering, je_julie, leviw+renderwatch, mlamouri+watch-blink_chromium.org, nektar+watch_chromium.org, nektarios, pdr+renderingwatchlist_chromium.org, nessy, Srirama, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Controls: move volume slider to modules/. This is also removing MediaControlElements.{h,cpp} from core/html/shadow/. BUG=662761 R=avayvod@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2830653002 Cr-Commit-Position: refs/heads/master@{#467043} Committed: https://chromium.googlesource.com/chromium/src/+/0718c3ee0d51683879cf7817f3615e8a0ed69a80

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : core_export move for win #

Patch Set 4 : happy win? #

Patch Set 5 : another try #

Patch Set 6 : moved implementation of LayoutSliderItem to its own file #

Patch Set 7 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -244 lines) Patch
M third_party/WebKit/Source/core/html/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/MediaControlElements.h View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +0 lines, -162 lines 0 comments Download
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutSliderItem.h View 1 2 3 4 5 6 1 chunk +10 lines, -15 lines 0 comments Download
A third_party/WebKit/Source/core/layout/api/LayoutSliderItem.cpp View 1 2 3 4 5 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMediaControls.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/media_controls/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.cpp View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 41 (28 generated)
mlamouri (slow - plz ping)
jochen@, PTAL at: - core/html/BUILD.gn - core/layout/LayoutTheme.cpp - MediaControlsPainter.cpp avayvod@, PTAL at everything else :)
3 years, 8 months ago (2017-04-19 10:53:01 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-20 09:44:28 UTC) #8
mlamouri (slow - plz ping)
+zqzhang@, can you PTAL :)
3 years, 8 months ago (2017-04-20 10:19:24 UTC) #10
Zhiqiang Zhang (Slow)
lgtm
3 years, 8 months ago (2017-04-20 10:39:38 UTC) #11
whywhat
lgtm
3 years, 8 months ago (2017-04-20 12:44:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830653002/20001
3 years, 8 months ago (2017-04-21 15:35:15 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/394961)
3 years, 8 months ago (2017-04-21 16:41:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830653002/40001
3 years, 8 months ago (2017-04-24 10:34:35 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/213938)
3 years, 8 months ago (2017-04-24 11:17:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830653002/100001
3 years, 8 months ago (2017-04-25 13:31:54 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/396755)
3 years, 8 months ago (2017-04-25 14:52:54 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830653002/120001
3 years, 8 months ago (2017-04-25 16:08:52 UTC) #38
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 17:59:50 UTC) #41
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/0718c3ee0d51683879cf7817f361...

Powered by Google App Engine
This is Rietveld 408576698