third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp - Issue 2820343002: Media Controls: move timeline related code to modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp

Issue 2820343002: Media Controls: move timeline related code to modules. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp ('k') | third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h » ('j') | third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp

index 08f93a30632cac5489f2892b0a533ba014b3c244..8efdbabcbdce361c13af4e4f2288c5b65136fadd 100644

--- a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp

@@ -26,7 +26,8 @@ bool MediaControlOverflowMenuButtonElement::WillRespondToMouseClickEvents() {

void MediaControlOverflowMenuButtonElement::DefaultEventHandler(Event* event) {

if (event->type() == EventTypeNames::click) {

- if (GetMediaControls().OverflowMenuVisible()) {

+ if (static_cast<MediaControlsImpl&>(GetMediaControls())

+ .OverflowMenuVisible()) {

Platform::Current()->RecordAction(

UserMetricsAction("Media.Controls.OverflowClose"));

} else {