Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

Issue 2820343002: Media Controls: move timeline related code to modules. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
index 227a699e50ef135548a91979550a1ffee8388c58..b31c8faab967c0c281f1f35b1a003a6e333a1bea 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
@@ -60,6 +60,7 @@
#include "modules/media_controls/elements/MediaControlPlayButtonElement.h"
#include "modules/media_controls/elements/MediaControlRemainingTimeDisplayElement.h"
#include "modules/media_controls/elements/MediaControlTextTrackListElement.h"
+#include "modules/media_controls/elements/MediaControlTimelineElement.h"
#include "modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.h"
#include "platform/EventDispatchForbiddenScope.h"
@@ -337,10 +338,8 @@ void MediaControlsImpl::InitializeControls() {
duration_display_ = new MediaControlRemainingTimeDisplayElement(*this);
panel_->AppendChild(duration_display_);
- MediaControlTimelineElement* timeline =
- MediaControlTimelineElement::Create(*this);
- timeline_ = timeline;
- panel_->AppendChild(timeline);
+ timeline_ = new MediaControlTimelineElement(*this);
+ panel_->AppendChild(timeline_);
mute_button_ = new MediaControlMuteButtonElement(*this);
panel_->AppendChild(mute_button_);

Powered by Google App Engine
This is Rietveld 408576698