Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2819043002: Reland of name PendingScript::Url() to UrlForClassicScript() (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) This CL doesn't change the behavior, because this is renaming only. Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a0d40bbc53dc0 > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84ef56c08e28a2e TBR=kouhei@chromium.org BUG=686281, 711703 Review-Url: https://codereview.chromium.org/2819043002 Cr-Commit-Position: refs/heads/master@{#466906} Committed: https://chromium.googlesource.com/chromium/src/+/8bb84356d2e79de6c4a88e323dc9c5d6a0df40c4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/ClassicPendingScript.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 31 (26 generated)
hiroshige
Created Reland of name PendingScript::Url() to UrlForClassicScript()
3 years, 8 months ago (2017-04-14 22:41:53 UTC) #1
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-15 04:32:51 UTC) #15
commit-bot: I haz the power
This CL has an open dependency (Issue 2653923008 Patch 760001). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-15 04:33:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819043002/200001
3 years, 8 months ago (2017-04-25 06:52:15 UTC) #28
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 06:56:53 UTC) #31
Message was sent while issue was closed.
Committed patchset #6 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/8bb84356d2e79de6c4a88e323dc9...

Powered by Google App Engine
This is Rietveld 408576698