|
|
Created:
3 years, 8 months ago by hiroshige Modified:
3 years, 8 months ago Reviewers:
kouhei (in TOK) CC:
chromium-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ )
This CL doesn't change the behavior, because this is renaming only.
Reason for revert:
Issue 711703 is fixed on
https://codereview.chromium.org/2653923008/.
Original issue's description:
> Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ )
>
> Reason for revert:
> https://codereview.chromium.org/2653923008/ is
> suspected to cause CHECK() failure (crbug.com/711703)
> inside PendingScript's prefinalizer.
>
> BUG=711703
>
> Original issue's description:
> > Rename PendingScript::Url() to UrlForClassicScript()
> >
> > Because it is/can be used only for classic scripts.
> >
> > BUG=686281
> >
> > Review-Url: https://codereview.chromium.org/2815163005
> > Cr-Commit-Position: refs/heads/master@{#464613}
> > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a0d40bbc53dc0
>
> TBR=kouhei@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=686281
>
> Review-Url: https://codereview.chromium.org/2822763002
> Cr-Commit-Position: refs/heads/master@{#464766}
> Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84ef56c08e28a2e
TBR=kouhei@chromium.org
BUG=686281, 711703
Review-Url: https://codereview.chromium.org/2819043002
Cr-Commit-Position: refs/heads/master@{#466906}
Committed: https://chromium.googlesource.com/chromium/src/+/8bb84356d2e79de6c4a88e323dc9c5d6a0df40c4
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #Patch Set 6 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 31 (26 generated)
Created Reland of name PendingScript::Url() to UrlForClassicScript()
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Description was changed from ========== Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a... > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84e... TBR=kouhei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711703 ========== to ========== Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a... > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84e... TBR=kouhei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711703 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a... > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84e... TBR=kouhei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711703 ========== to ========== Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a... > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84e... TBR=kouhei@chromium.org BUG=686281, 711703 ==========
Description was changed from ========== Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a... > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84e... TBR=kouhei@chromium.org BUG=686281, 711703 ========== to ========== Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) This CL doesn't change the behavior. Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a... > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84e... TBR=kouhei@chromium.org BUG=686281, 711703 ==========
Description was changed from ========== Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) This CL doesn't change the behavior. Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a... > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84e... TBR=kouhei@chromium.org BUG=686281, 711703 ========== to ========== Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) This CL doesn't change the behavior, because this is renaming only. Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a... > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84e... TBR=kouhei@chromium.org BUG=686281, 711703 ==========
The CQ bit was checked by kouhei@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2653923008 Patch 760001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org Link to the patchset: https://codereview.chromium.org/2819043002/#ps200001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 200001, "attempt_start_ts": 1493103111864030, "parent_rev": "8cc56abb22687b014e5bd8102cb83f438baf2ff5", "commit_rev": "8bb84356d2e79de6c4a88e323dc9c5d6a0df40c4"}
Message was sent while issue was closed.
Description was changed from ========== Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) This CL doesn't change the behavior, because this is renaming only. Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a... > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84e... TBR=kouhei@chromium.org BUG=686281, 711703 ========== to ========== Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ ) This CL doesn't change the behavior, because this is renaming only. Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) > > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Rename PendingScript::Url() to UrlForClassicScript() > > > > Because it is/can be used only for classic scripts. > > > > BUG=686281 > > > > Review-Url: https://codereview.chromium.org/2815163005 > > Cr-Commit-Position: refs/heads/master@{#464613} > > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a... > > TBR=kouhei@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686281 > > Review-Url: https://codereview.chromium.org/2822763002 > Cr-Commit-Position: refs/heads/master@{#464766} > Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84e... TBR=kouhei@chromium.org BUG=686281, 711703 Review-Url: https://codereview.chromium.org/2819043002 Cr-Commit-Position: refs/heads/master@{#466906} Committed: https://chromium.googlesource.com/chromium/src/+/8bb84356d2e79de6c4a88e323dc9... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:200001) as https://chromium.googlesource.com/chromium/src/+/8bb84356d2e79de6c4a88e323dc9... |