Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2815163005: Rename PendingScript::Url() to UrlForClassicScript() (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PendingScript::Url() to UrlForClassicScript() Because it is/can be used only for classic scripts. BUG=686281 Review-Url: https://codereview.chromium.org/2815163005 Cr-Commit-Position: refs/heads/master@{#464613} Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a0d40bbc53dc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/ClassicPendingScript.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (13 generated)
hiroshige
PTAL
3 years, 8 months ago (2017-04-13 18:10:11 UTC) #5
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-13 23:30:07 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 2820533003 Patch 1). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-13 23:30:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815163005/1
3 years, 8 months ago (2017-04-13 23:44:57 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a0d40bbc53dc0
3 years, 8 months ago (2017-04-13 23:50:18 UTC) #17
hiroshige
3 years, 8 months ago (2017-04-14 18:58:22 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2822763002/ by hiroshige@chromium.org.

The reason for reverting is: https://codereview.chromium.org/2653923008/ is
suspected to cause CHECK() failure (crbug.com/711703)
inside PendingScript's prefinalizer.

BUG=711703.

Powered by Google App Engine
This is Rietveld 408576698