Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

Issue 2819043002: Reland of name PendingScript::Url() to UrlForClassicScript() (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/PendingScript.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
index ec40bbaef322f0299f39ab588815737f3adf5ef7..6836584ed6276ec7f659f655abe8dc6a542f2b73 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
@@ -339,8 +339,8 @@ void HTMLParserScriptRunner::PossiblyFetchBlockedDocWriteScript(
CHECK_EQ(pending_script->GetScriptType(), ScriptType::kClassic);
if (!pending_script->ErrorOccurred()) {
- EmitWarningForDocWriteScripts(pending_script->Url().GetString(),
- *document_);
+ EmitWarningForDocWriteScripts(
+ pending_script->UrlForClassicScript().GetString(), *document_);
return;
}
@@ -348,7 +348,8 @@ void HTMLParserScriptRunner::PossiblyFetchBlockedDocWriteScript(
// ERR_CACHE_MISS but other errors are rare with
// WebCachePolicy::ReturnCacheDataDontLoad.
- EmitErrorForDocWriteScripts(pending_script->Url().GetString(), *document_);
+ EmitErrorForDocWriteScripts(pending_script->UrlForClassicScript().GetString(),
+ *document_);
TextPosition starting_position = ParserBlockingScript()->StartingPosition();
bool is_parser_inserted = script_loader->IsParserInserted();
// Remove this resource entry from memory cache as the new request
« no previous file with comments | « third_party/WebKit/Source/core/dom/PendingScript.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698