|
|
DescriptionReland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ )
This CL doesn't change the behavior, because ModulePendingScript is not
used at this time.
Reason for revert:
Issue 711703 is fixed on
https://codereview.chromium.org/2653923008/.
Original issue's description:
> Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ )
>
> Reason for revert:
> Reason for revert:
> https://codereview.chromium.org/2653923008/ is
> suspected to cause CHECK() failure (crbug.com/711703)
> inside PendingScript's prefinalizer.
>
> BUG=711703
>
> Original issue's description:
> > Introduce ModulePendingScript
> >
> > BUG=594639
> >
> > Review-Url: https://codereview.chromium.org/2815453006
> > Cr-Commit-Position: refs/heads/master@{#464627}
> > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59a88f77bb50f5
>
> TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594639
>
> Review-Url: https://codereview.chromium.org/2816043005
> Cr-Commit-Position: refs/heads/master@{#464765}
> Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78cc4473eb50c6f
TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chromium.org
BUG=594639, 711703
Review-Url: https://codereview.chromium.org/2820703003
Cr-Commit-Position: refs/heads/master@{#466909}
Committed: https://chromium.googlesource.com/chromium/src/+/11d59e51532e90c9178e541f5605f12846a4ebc5
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #Patch Set 6 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 33 (29 generated)
Created Reland of Introduce ModulePendingScript
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59... > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78c... TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711703 ========== to ========== Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59... > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78c... BUG=594639, 711703 ==========
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59... > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78c... BUG=594639, 711703 ========== to ========== Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59... > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78c... TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... BUG=594639, 711703 ==========
Description was changed from ========== Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59... > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78c... TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... BUG=594639, 711703 ========== to ========== Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59... > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78c... TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... BUG=594639, 711703 ==========
Description was changed from ========== Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59... > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78c... TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... BUG=594639, 711703 ========== to ========== Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) This CL doesn't change the behavior, because ModulePendingScript is not used at this time. Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59... > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78c... TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... BUG=594639, 711703 ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org Link to the patchset: https://codereview.chromium.org/2820703003/#ps200001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 200001, "attempt_start_ts": 1493103450874710, "parent_rev": "fb75c0c4e9721fcbca5f6229cf2e5dab5e8d9fcd", "commit_rev": "11d59e51532e90c9178e541f5605f12846a4ebc5"}
Message was sent while issue was closed.
Description was changed from ========== Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) This CL doesn't change the behavior, because ModulePendingScript is not used at this time. Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59... > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78c... TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... BUG=594639, 711703 ========== to ========== Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) This CL doesn't change the behavior, because ModulePendingScript is not used at this time. Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59... > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78c... TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chrom... BUG=594639, 711703 Review-Url: https://codereview.chromium.org/2820703003 Cr-Commit-Position: refs/heads/master@{#466909} Committed: https://chromium.googlesource.com/chromium/src/+/11d59e51532e90c9178e541f5605... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:200001) as https://chromium.googlesource.com/chromium/src/+/11d59e51532e90c9178e541f5605... |