Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2820703003: Reland of Introduce ModulePendingScript (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ ) This CL doesn't change the behavior, because ModulePendingScript is not used at this time. Reason for revert: Issue 711703 is fixed on https://codereview.chromium.org/2653923008/. Original issue's description: > Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) > > Reason for revert: > Reason for revert: > https://codereview.chromium.org/2653923008/ is > suspected to cause CHECK() failure (crbug.com/711703) > inside PendingScript's prefinalizer. > > BUG=711703 > > Original issue's description: > > Introduce ModulePendingScript > > > > BUG=594639 > > > > Review-Url: https://codereview.chromium.org/2815453006 > > Cr-Commit-Position: refs/heads/master@{#464627} > > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59a88f77bb50f5 > > TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594639 > > Review-Url: https://codereview.chromium.org/2816043005 > Cr-Commit-Position: refs/heads/master@{#464765} > Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78cc4473eb50c6f TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chromium.org BUG=594639, 711703 Review-Url: https://codereview.chromium.org/2820703003 Cr-Commit-Position: refs/heads/master@{#466909} Committed: https://chromium.googlesource.com/chromium/src/+/11d59e51532e90c9178e541f5605f12846a4ebc5

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ModulePendingScript.h View 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ModulePendingScript.cpp View 1 chunk +82 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 33 (29 generated)
hiroshige
Created Reland of Introduce ModulePendingScript
3 years, 8 months ago (2017-04-14 22:42:40 UTC) #1
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-15 01:06:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820703003/200001
3 years, 8 months ago (2017-04-25 06:57:48 UTC) #30
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 07:03:40 UTC) #33
Message was sent while issue was closed.
Committed patchset #6 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/11d59e51532e90c9178e541f5605...

Powered by Google App Engine
This is Rietveld 408576698