Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2822763002: Revert of Rename PendingScript::Url() to UrlForClassicScript() (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) Reason for revert: https://codereview.chromium.org/2653923008/ is suspected to cause CHECK() failure (crbug.com/711703) inside PendingScript's prefinalizer. BUG=711703 Original issue's description: > Rename PendingScript::Url() to UrlForClassicScript() > > Because it is/can be used only for classic scripts. > > BUG=686281 > > Review-Url: https://codereview.chromium.org/2815163005 > Cr-Commit-Position: refs/heads/master@{#464613} > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a0d40bbc53dc0 TBR=kouhei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686281 Review-Url: https://codereview.chromium.org/2822763002 Cr-Commit-Position: refs/heads/master@{#464766} Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84ef56c08e28a2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/ClassicPendingScript.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hiroshige
Created Revert of Rename PendingScript::Url() to UrlForClassicScript()
3 years, 8 months ago (2017-04-14 18:58:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822763002/1
3 years, 8 months ago (2017-04-14 18:58:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84ef56c08e28a2e
3 years, 8 months ago (2017-04-14 19:00:18 UTC) #6
hiroshige
3 years, 8 months ago (2017-04-14 22:41:53 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2819043002/ by hiroshige@chromium.org.

The reason for reverting is: Issue 711703 is fixed on
https://codereview.chromium.org/2653923008/..

Powered by Google App Engine
This is Rietveld 408576698