Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 2818163002: MD Settings: Move various non-Polymer properties outside of "properties". (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Move various non-Polymer properties outside of "properties". BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2818163002 Cr-Commit-Position: refs/heads/master@{#464799} Committed: https://chromium.googlesource.com/chromium/src/+/fd475a9ac2f060c7d7ecc43b3ea2b526fa017dcb

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -78 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.js View 1 chunk +18 lines, -25 lines 0 comments Download
M chrome/browser/resources/settings/people_page/manage_profile.js View 1 1 chunk +8 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.js View 1 2 chunks +21 lines, -26 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
dpapad
This is a follow up from https://codereview.chromium.org/2799563003.
3 years, 8 months ago (2017-04-14 20:40:10 UTC) #12
tommycli
On 2017/04/14 20:40:10, dpapad wrote: > This is a follow up from https://codereview.chromium.org/2799563003. lgtm
3 years, 8 months ago (2017-04-14 20:44:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818163002/20001
3 years, 8 months ago (2017-04-14 21:20:49 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 21:27:09 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fd475a9ac2f060c7d7ecc43b3ea2...

Powered by Google App Engine
This is Rietveld 408576698