Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2845)

Unified Diff: chrome/browser/resources/settings/people_page/change_picture.js

Issue 2818163002: MD Settings: Move various non-Polymer properties outside of "properties". (Closed)
Patch Set: fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/change_picture.js
diff --git a/chrome/browser/resources/settings/people_page/change_picture.js b/chrome/browser/resources/settings/people_page/change_picture.js
index f07d3cda4f0076ef0066f4304beae74d4e2856a0..96ad5c23a5624ef5de5e87f7a71c29fb2f049f1b 100644
--- a/chrome/browser/resources/settings/people_page/change_picture.js
+++ b/chrome/browser/resources/settings/people_page/change_picture.js
@@ -88,41 +88,34 @@ Polymer({
value: function() { return []; },
},
- /**
- * The fallback image to be selected when the user discards the Old image.
- * This may be null if the user started with the Old image.
- * @private {?ChangePictureImageElement}
- */
- fallbackImage_: Object,
-
- /**
- * Type of the last selected icon. This is used to jump back to the camera
- * after the user discards a newly taken photo.
- * @private {string}
- */
- lastSelectedImageType_: {
- type: String,
- value: '',
- },
-
/** @private */
selectionTypesEnum_: {
type: Object,
value: ChangePictureSelectionTypes,
readOnly: true,
},
-
- /** @private {!settings.ChangePictureBrowserProxy} */
- browserProxy_: {
- type: Object,
- value: function() {
- return settings.ChangePictureBrowserProxyImpl.getInstance();
- },
- },
},
+ /** @private {?settings.ChangePictureBrowserProxy} */
+ browserProxy_: null,
+
+ /**
+ * The fallback image to be selected when the user discards the Old image.
+ * This may be null if the user started with the Old image.
+ * @private {?ChangePictureImageElement}
+ */
+ fallbackImage_: null,
+
+ /**
+ * Type of the last selected icon. This is used to jump back to the camera
+ * after the user discards a newly taken photo.
+ * @private {string}
+ */
+ lastSelectedImageType_: '',
+
/** @override */
attached: function() {
+ this.browserProxy_ = settings.ChangePictureBrowserProxyImpl.getInstance();
this.addWebUIListener('default-images-changed',
this.receiveDefaultImages_.bind(this));
this.addWebUIListener('selected-image-changed',

Powered by Google App Engine
This is Rietveld 408576698