Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 2818163002: MD Settings: Move various non-Polymer properties outside of "properties". (Closed)
Patch Set: fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/people_page.js
diff --git a/chrome/browser/resources/settings/people_page/people_page.js b/chrome/browser/resources/settings/people_page/people_page.js
index b90834a8cd47d05a4b174ee763c815a53ec28676..f587973a9b14cad2c2c5634d9efa88e6afb28abf 100644
--- a/chrome/browser/resources/settings/people_page/people_page.js
+++ b/chrome/browser/resources/settings/people_page/people_page.js
@@ -73,14 +73,6 @@ Polymer({
},
// </if>
- /** @private {!settings.SyncBrowserProxy} */
- syncBrowserProxy_: {
- type: Object,
- value: function() {
- return settings.SyncBrowserProxyImpl.getInstance();
- },
- },
-
/** @private */
showDisconnectDialog_: Boolean,
@@ -126,6 +118,9 @@ Polymer({
},
},
+ /** @private {?settings.SyncBrowserProxy} */
+ syncBrowserProxy_: null,
+
/** @override */
attached: function() {
var profileInfoProxy = settings.ProfileInfoBrowserProxyImpl.getInstance();
@@ -141,6 +136,7 @@ Polymer({
this.addWebUIListener('profile-stats-count-ready',
this.handleProfileStatsCount_.bind(this));
+ this.syncBrowserProxy_ = settings.SyncBrowserProxyImpl.getInstance();
this.syncBrowserProxy_.getSyncStatus().then(
this.handleSyncStatus_.bind(this));
this.addWebUIListener('sync-status-changed',

Powered by Google App Engine
This is Rietveld 408576698