Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2799563003: MD Settings: Move browserProxies outside of Polymer "properties". (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Move browserProxies outside of Polymer "properties". BUG=597347 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2799563003 Cr-Commit-Position: refs/heads/master@{#462703} Committed: https://chromium.googlesource.com/chromium/src/+/99cc887ad000b29513c3d2613efa46f26199e504

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages

Total messages: 16 (11 generated)
dpapad
3 years, 8 months ago (2017-04-06 20:46:15 UTC) #8
Dan Beam
lgtm but should all of these be explicitly nullable (?)?
3 years, 8 months ago (2017-04-06 20:49:25 UTC) #9
dpapad
On 2017/04/06 at 20:49:25, dbeam wrote: > lgtm but should all of these be explicitly ...
3 years, 8 months ago (2017-04-06 22:13:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799563003/20001
3 years, 8 months ago (2017-04-06 22:15:45 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 00:20:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/99cc887ad000b29513c3d2613efa...

Powered by Google App Engine
This is Rietveld 408576698