Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: chrome/browser/resources/settings/people_page/sync_page.js

Issue 2818163002: MD Settings: Move various non-Polymer properties outside of "properties". (Closed)
Patch Set: fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/sync_page.js
diff --git a/chrome/browser/resources/settings/people_page/sync_page.js b/chrome/browser/resources/settings/people_page/sync_page.js
index 3473acdc58f16c2fef1bea4460d5b77df5c20610..ae28f92d98a29fb442b3f33a5b4ee0a802aabe2f 100644
--- a/chrome/browser/resources/settings/people_page/sync_page.js
+++ b/chrome/browser/resources/settings/people_page/sync_page.js
@@ -72,15 +72,6 @@ Polymer({
},
/**
- * Caches the individually selected synced data types. This is used to
- * be able to restore the selections after checking and unchecking Sync All.
- * @private
- */
- cachedSyncPrefs_: {
- type: Object,
- },
-
- /**
* Whether the "create passphrase" inputs should be shown. These inputs
* give the user the opportunity to use a custom passphrase instead of
* authenticating with their Google credentials.
@@ -117,25 +108,29 @@ Polymer({
type: String,
value: '',
},
+ },
- /** @private {!settings.SyncBrowserProxy} */
- browserProxy_: {
- type: Object,
- value: function() {
- return settings.SyncBrowserProxyImpl.getInstance();
- },
- },
+ /** @private {?settings.SyncBrowserProxy} */
+ browserProxy_: null,
- /**
- * The unload callback is needed because the sign-in flow needs to know
- * if the user has closed the tab with the sync settings. This property is
- * non-null if the user is currently navigated on the sync settings route.
- * @private {Function}
- */
- unloadCallback_: {
- type: Object,
- value: null,
- },
+ /**
+ * The unload callback is needed because the sign-in flow needs to know
+ * if the user has closed the tab with the sync settings. This property is
+ * non-null if the user is currently navigated on the sync settings route.
+ * @private {?Function}
+ */
+ unloadCallback_: null,
+
+ /**
+ * Caches the individually selected synced data types. This is used to
+ * be able to restore the selections after checking and unchecking Sync All.
+ * @private {?Object}
+ */
+ cachedSyncPrefs_: null,
+
+ /** @override */
+ created: function() {
+ this.browserProxy_ = settings.SyncBrowserProxyImpl.getInstance();
},
/** @override */
« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698