Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2815513008: [ObjC ARC] Converts ios/chrome/browser/ui/settings:settings_arc to ARC. (Closed)

Created:
3 years, 8 months ago by stkhapugin
Modified:
3 years, 8 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings_arc to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2815513008 Cr-Commit-Position: refs/heads/master@{#464414} Committed: https://chromium.googlesource.com/chromium/src/+/caa0789757799f125a2c12d474b9f7cd6b0f73c8

Patch Set 1 #

Patch Set 2 : Removes accidental retain from another CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -228 lines) Patch
M ios/chrome/browser/ui/settings/BUILD.gn View 3 chunks +107 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm View 3 chunks +22 lines, -22 lines 0 comments Download
M ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm View 23 chunks +47 lines, -49 lines 0 comments Download
M ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm View 14 chunks +26 lines, -34 lines 0 comments Download
M ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm View 8 chunks +16 lines, -13 lines 0 comments Download
M ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller.mm View 6 chunks +9 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.mm View 5 chunks +8 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.mm View 6 chunks +16 lines, -14 lines 0 comments Download
M ios/chrome/browser/ui/settings/bar_button_activity_indicator.mm View 2 chunks +7 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm View 13 chunks +29 lines, -32 lines 0 comments Download
M ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm View 16 chunks +37 lines, -42 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
stkhapugin
PTAL
3 years, 8 months ago (2017-04-12 17:31:21 UTC) #6
lpromero
lgtm
3 years, 8 months ago (2017-04-13 11:05:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815513008/20001
3 years, 8 months ago (2017-04-13 15:04:28 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 15:29:16 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/caa0789757799f125a2c12d474b9...

Powered by Google App Engine
This is Rietveld 408576698