Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2814813003: [ObjC ARC] Converts ios/chrome/browser/ui/settings:settings_arc_transition to ARC. (Closed)

Created:
3 years, 8 months ago by stkhapugin
Modified:
3 years, 8 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, gcasto+watchlist_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings_arc_transition to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2814813003 Cr-Commit-Position: refs/heads/master@{#464459} Committed: https://chromium.googlesource.com/chromium/src/+/a19562cbe74df0ff0ca935a9c5025617df8e33a4

Patch Set 1 #

Patch Set 2 : fix gn #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -254 lines) Patch
M ios/chrome/browser/ui/settings/BUILD.gn View 1 2 chunks +21 lines, -21 lines 0 comments Download
M ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm View 9 chunks +28 lines, -30 lines 0 comments Download
M ios/chrome/browser/ui/settings/contextual_search_collection_view_controller.mm View 7 chunks +12 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/settings/dataplan_usage_collection_view_controller.mm View 3 chunks +10 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/settings/do_not_track_collection_view_controller.mm View 3 chunks +8 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm View 3 chunks +8 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/settings/import_data_collection_view_controller.mm View 9 chunks +25 lines, -23 lines 0 comments Download
M ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm View 26 chunks +82 lines, -92 lines 0 comments Download
M ios/chrome/browser/ui/settings/native_apps_collection_view_controller.mm View 9 chunks +18 lines, -18 lines 0 comments Download
M ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm View 9 chunks +34 lines, -38 lines 0 comments Download
M ios/chrome/browser/ui/settings/physical_web_collection_view_controller.mm View 4 chunks +8 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
stkhapugin
PTAL
3 years, 8 months ago (2017-04-12 17:31:42 UTC) #4
lpromero
lgtm
3 years, 8 months ago (2017-04-13 10:42:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814813003/40001
3 years, 8 months ago (2017-04-13 17:37:22 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 17:45:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a19562cbe74df0ff0ca935a9c502...

Powered by Google App Engine
This is Rietveld 408576698