[ObjC ARC] Converts ios/chrome/browser/ui/settings:unit_tests to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/settings:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* added autorelease pools in tests related to SettingsNavigationControllerTest to fix
 memory issues, specifically early deallocation of SigninManager where the observers
 (SigninObserverBridge of SettingsCollectionViewController) stored in WeakNSObject
 are not deallocated yet (in autorelease pool)
* Removes NS_RETURNS_RETAINED from a method that doesn't really need it


BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2806323003
Cr-Commit-Position: refs/heads/master@{#464013}
Committed: https://chromium.googlesource.com/chromium/src/+/996f406fabe039d6f6f44528b63e5e90b38d22cc

[stkhapugin, 2017-04-10 16:49:19]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 16:49:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-04-10 16:59:16]

[ObjC ARC] Converts ios/chrome/browser/ui/settings:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

[stkhapugin, 2017-04-10 16:59:17]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 16:59:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-04-11 15:11:23]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/settings:unit_tests_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/settings:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* added autorelease pools in tests related to SettingsNavigationControllerTest
to fix
 memory issues, specifically early deallocation of SigninManager where the
observers
 (SigninObserverBridge of SettingsCollectionViewController) stored in
WeakNSObject
 are not deallocated yet (in autorelease pool)
* Removes NS_RETURNS_RETAINED from a method that doesn't really need it


BUG=624363
TEST=None
==========

[stkhapugin, 2017-04-11 15:11:34]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 15:12:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 15:23:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 15:23:02]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-04-12 12:07:08]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 12:07:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 13:45:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 13:45:22]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-04-12 14:00:58]

stkhapugin@chromium.org changed reviewers:
+ lpromero@chromium.org

[stkhapugin, 2017-04-12 14:00:59]

PTAL. Mostly the changes are trivial, but if you want, I can try to split it up.

[lpromero, 2017-04-12 14:06:26]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-04-12 14:06:26]

lgtm

[commit-bot: I haz the power, 2017-04-12 14:06:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 14:11:56]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1492005986205810,
"parent_rev": "b3f6bfc64c3ab48d05200ca4890657150d6529f7", "commit_rev":
"996f406fabe039d6f6f44528b63e5e90b38d22cc"}

[commit-bot: I haz the power, 2017-04-12 14:12:51]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/settings:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* added autorelease pools in tests related to SettingsNavigationControllerTest
to fix
 memory issues, specifically early deallocation of SigninManager where the
observers
 (SigninObserverBridge of SettingsCollectionViewController) stored in
WeakNSObject
 are not deallocated yet (in autorelease pool)
* Removes NS_RETURNS_RETAINED from a method that doesn't really need it


BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/settings:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* added autorelease pools in tests related to SettingsNavigationControllerTest
to fix
 memory issues, specifically early deallocation of SigninManager where the
observers
 (SigninObserverBridge of SettingsCollectionViewController) stored in
WeakNSObject
 are not deallocated yet (in autorelease pool)
* Removes NS_RETURNS_RETAINED from a method that doesn't really need it


BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2806323003
Cr-Commit-Position: refs/heads/master@{#464013}
Committed:
https://chromium.googlesource.com/chromium/src/+/996f406fabe039d6f6f44528b63e...
==========

[commit-bot: I haz the power, 2017-04-12 14:12:53]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/996f406fabe039d6f6f44528b63e...

[stkhapugin, 2017-04-12 14:33:15]

Thank you!