Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2813223002: [ObjC ARC] Converts ios/chrome/browser/ui/settings:settings to ARC. (Closed)

Created:
3 years, 8 months ago by stkhapugin
Modified:
3 years, 6 months ago
Reviewers:
baxley, lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2813223002 Cr-Commit-Position: refs/heads/master@{#472426} Committed: https://chromium.googlesource.com/chromium/src/+/659885eebc27bf7a49b806d2f8b104b547b36605

Patch Set 1 #

Patch Set 2 : remerge targets #

Patch Set 3 : rebase #

Total comments: 4

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : reabse #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -543 lines) Patch
M ios/chrome/browser/ui/settings/BUILD.gn View 1 2 3 4 5 6 4 chunks +3 lines, -108 lines 0 comments Download
M ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm View 1 2 3 4 5 6 17 chunks +48 lines, -49 lines 0 comments Download
M ios/chrome/browser/ui/settings/reauthentication_module.mm View 3 chunks +14 lines, -14 lines 0 comments Download
M ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm View 1 2 3 4 5 6 17 chunks +35 lines, -43 lines 0 comments Download
M ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller.mm View 1 2 3 4 5 6 5 chunks +8 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_collection_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/settings/settings_collection_view_controller.mm View 1 2 3 4 5 6 32 chunks +95 lines, -96 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_navigation_controller.mm View 1 2 4 24 chunks +54 lines, -60 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm View 10 chunks +22 lines, -33 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_utils.mm View 1 chunk +9 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/settings/sync_create_passphrase_collection_view_controller.mm View 5 chunks +9 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm View 5 chunks +10 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm View 13 chunks +29 lines, -34 lines 1 comment Download
M ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm View 1 2 3 4 5 6 19 chunks +36 lines, -41 lines 0 comments Download
M ios/chrome/browser/ui/settings/time_range_selector_collection_view_controller.mm View 1 2 3 4 5 6 5 chunks +7 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/settings/translate_collection_view_controller.mm View 1 2 3 4 5 6 8 chunks +19 lines, -18 lines 0 comments Download
M ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.mm View 1 2 3 4 5 6 5 chunks +10 lines, -8 lines 0 comments Download
M ios/chrome/test/earl_grey/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 43 (29 generated)
stkhapugin
PTAL
3 years, 8 months ago (2017-04-12 17:32:02 UTC) #4
lpromero
lgtm https://codereview.chromium.org/2813223002/diff/40001/ios/chrome/browser/ui/settings/settings_collection_view_controller.h File ios/chrome/browser/ui/settings/settings_collection_view_controller.h (right): https://codereview.chromium.org/2813223002/diff/40001/ios/chrome/browser/ui/settings/settings_collection_view_controller.h#newcode37 ios/chrome/browser/ui/settings/settings_collection_view_controller.h:37: @property(weak, nonatomic, readonly) Internally, it's a strong reference. ...
3 years, 8 months ago (2017-04-13 10:02:29 UTC) #5
stkhapugin
Good catches. These did not affect the logic of the program, because both properties used ...
3 years, 8 months ago (2017-04-13 14:48:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813223002/60001
3 years, 8 months ago (2017-04-14 09:40:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/411451)
3 years, 8 months ago (2017-04-14 09:47:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813223002/80001
3 years, 8 months ago (2017-04-14 11:36:49 UTC) #22
commit-bot: I haz the power
Failed to apply patch for ios/chrome/browser/ui/settings/settings_collection_view_controller.mm: While running git apply --index -3 -p1; error: patch ...
3 years, 8 months ago (2017-04-14 12:32:59 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813223002/100001
3 years, 7 months ago (2017-05-03 15:17:44 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/444461) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-05-03 15:21:35 UTC) #29
stkhapugin
+baxley for owners of EG build.gn
3 years, 7 months ago (2017-05-16 15:27:51 UTC) #32
baxley
ios/chrome/test/earl_grey/ LGTM
3 years, 7 months ago (2017-05-16 15:49:53 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813223002/120001
3 years, 7 months ago (2017-05-17 11:47:58 UTC) #39
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/659885eebc27bf7a49b806d2f8b104b547b36605
3 years, 7 months ago (2017-05-17 11:53:11 UTC) #42
lpromero
3 years, 6 months ago (2017-06-15 08:31:49 UTC) #43
Message was sent while issue was closed.
https://codereview.chromium.org/2813223002/diff/120001/ios/chrome/browser/ui/...
File
ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm
(right):

https://codereview.chromium.org/2813223002/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm:434:
self.navigationItem.leftBarButtonItem = savedLeftButton_ = nil;
Wow. That's a bad one (idem below). We should make a pass on the entire code
base to see if this happened somewhere else.

Powered by Google App Engine
This is Rietveld 408576698