[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2813223002
Cr-Commit-Position: refs/heads/master@{#472426}
Committed: https://chromium.googlesource.com/chromium/src/+/659885eebc27bf7a49b806d2f8b104b547b36605

[stkhapugin, 2017-04-12 16:29:06]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 16:30:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-04-12 17:32:02]

stkhapugin@chromium.org changed reviewers:
+ lpromero@chromium.org

[stkhapugin, 2017-04-12 17:32:02]

PTAL

[lpromero, 2017-04-13 10:02:29]

lgtm

https://codereview.chromium.org/2813223002/diff/40001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/settings_collection_view_controller.h
(right):

https://codereview.chromium.org/2813223002/diff/40001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/settings_collection_view_controller.h:37:
@property(weak, nonatomic, readonly)
Internally, it's a strong reference. I think it was just missing initially and
the tool just made it clear.

https://codereview.chromium.org/2813223002/diff/40001/ios/chrome/browser/ui/s...
File
ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.h
(right):

https://codereview.chromium.org/2813223002/diff/40001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.h:38:
@property(weak, nonatomic, readonly) UITextField* passphrase;
Idem, this should be strong.

[lpromero, 2017-04-13 11:04:11]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 11:04:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 11:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 11:08:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[stkhapugin, 2017-04-13 14:48:31]

Good catches. These did not affect the logic of the program, because both
properties used explicitly typed ivars that were both strong. Unfortunately we
have plenty of these properties that are not declaring storage type and are
randomly backed by scoped_nsobject or plain pointer. 

Thanks!

https://codereview.chromium.org/2813223002/diff/40001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/settings_collection_view_controller.h
(right):

https://codereview.chromium.org/2813223002/diff/40001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/settings_collection_view_controller.h:37:
@property(weak, nonatomic, readonly)
On 2017/04/13 10:02:29, lpromero wrote:
> Internally, it's a strong reference. I think it was just missing initially and
> the tool just made it clear.

Done.

https://codereview.chromium.org/2813223002/diff/40001/ios/chrome/browser/ui/s...
File
ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.h
(right):

https://codereview.chromium.org/2813223002/diff/40001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.h:38:
@property(weak, nonatomic, readonly) UITextField* passphrase;
On 2017/04/13 10:02:29, lpromero wrote:
> Idem, this should be strong.

Done.

[stkhapugin, 2017-04-13 15:13:31]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 15:14:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 16:12:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 16:12:57]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-04-14 09:40:16]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-04-14 09:40:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2813223002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-14 09:40:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 09:47:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 09:47:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[stkhapugin, 2017-04-14 11:36:34]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-04-14 11:36:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2813223002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-14 11:36:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 12:32:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 12:32:59]

Failed to apply patch for
ios/chrome/browser/ui/settings/settings_collection_view_controller.mm:
While running git apply --index -3 -p1;
  error: patch failed:
ios/chrome/browser/ui/settings/settings_collection_view_controller.mm:188
  Falling back to three-way merge...
  Applied patch to
'ios/chrome/browser/ui/settings/settings_collection_view_controller.mm' with
conflicts.
  U ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

Patch:      
ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
Index: ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
diff --git
a/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
b/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
index
a582f938a92e106f026a4b46bf7e16a64c38d208..bbf03b3f8aae232c2ecfd6bcfb0a5b022e8147aa
100644
--- a/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
@@ -6,9 +6,7 @@
 
 #include <memory>
 
-#import "base/ios/weak_nsobject.h"
 #import "base/mac/foundation_util.h"
-#import "base/mac/scoped_nsobject.h"
 #include "base/metrics/user_metrics.h"
 #include "base/scoped_observer.h"
 #include "base/strings/sys_string_conversions.h"
@@ -75,8 +73,13 @@
 #import "ios/public/provider/chrome/browser/signin/chrome_identity.h"
 #import "ios/public/provider/chrome/browser/signin/signin_resources_provider.h"
 #include "ios/public/provider/chrome/browser/voice/voice_search_prefs.h"
+#import
"ios/third_party/material_components_ios/src/components/Buttons/src/MaterialButtons.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 NSString* const kSettingsCollectionViewId = @"kSettingsCollectionViewId";
 NSString* const kSettingsSignInCellId = @"kSettingsSignInCellId";
 NSString* const kSettingsAccountCellId = @"kSettingsAccountCellId";
@@ -143,7 +146,7 @@ class SigninObserverBridge : public
SigninManagerBase::Observer {
                        const std::string& username) override;
 
  private:
-  base::WeakNSObject<SettingsCollectionViewController> owner_;
+  __weak SettingsCollectionViewController* owner_;
   ScopedObserver<SigninManager, SigninObserverBridge> observer_;
 };
 
@@ -188,28 +191,27 @@ void SigninObserverBridge::GoogleSignedOut(const
std::string& account_id,
   ios::ChromeBrowserState* _currentBrowserState;  // weak
   std::unique_ptr<SigninObserverBridge> _notificationBridge;
   std::unique_ptr<SyncObserverBridge> _syncObserverBridge;
-  base::scoped_nsobject<SigninInteractionController>
-      _signinInteractionController;
+  SigninInteractionController* _signinInteractionController;
   // Whether the impression of the Signin button has already been recorded.
   BOOL _hasRecordedSigninImpression;
   // PrefBackedBoolean for ShowMemoryDebugTools switch.
-  base::scoped_nsobject<PrefBackedBoolean> _showMemoryDebugToolsEnabled;
+  PrefBackedBoolean* _showMemoryDebugToolsEnabled;
   // The item related to the switch for the show suggestions setting.
-  base::scoped_nsobject<CollectionViewSwitchItem> _showMemoryDebugToolsItem;
+  CollectionViewSwitchItem* _showMemoryDebugToolsItem;
 
-  // Mediator to configure the sign-in promo cell. Also used to received
-  // identity update notifications.
-  base::scoped_nsobject<SigninPromoViewMediator> _signinPromoViewMediator;
   // Item in the Sign-in section. Either CollectionViewAccountItem,
   // AccountSignInItem or SigninPromoItem.
   CollectionViewItem* _signinSectionItem;
+  // Mediator to configure the sign-in promo cell. Also used to received
+  // identity update notifications.
+  SigninPromoViewMediator* _signinPromoViewMediator;
 
   // Cached resized profile image.
-  base::scoped_nsobject<UIImage> _resizedImage;
-  base::WeakNSObject<UIImage> _oldImage;
+  UIImage* _resizedImage;
+  __weak UIImage* _oldImage;
 
   // Identity object and observer used for Account Item refresh.
-  base::scoped_nsobject<ChromeIdentity> _identity;
+  ChromeIdentity* _identity;
   std::unique_ptr<ChromeIdentityServiceObserverBridge>
_identityServiceObserver;
 
   // PrefMember for voice locale code.
@@ -222,10 +224,10 @@ void SigninObserverBridge::GoogleSignedOut(const
std::string& account_id,
   PrefChangeRegistrar _prefChangeRegistrar;
 
   // Updatable Items.
-  base::scoped_nsobject<CollectionViewDetailItem> _voiceSearchDetailItem;
-  base::scoped_nsobject<CollectionViewDetailItem> _defaultSearchEngineItem;
-  base::scoped_nsobject<CollectionViewDetailItem> _savePasswordsDetailItem;
-  base::scoped_nsobject<CollectionViewDetailItem> _autoFillDetailItem;
+  CollectionViewDetailItem* _voiceSearchDetailItem;
+  CollectionViewDetailItem* _defaultSearchEngineItem;
+  CollectionViewDetailItem* _savePasswordsDetailItem;
+  CollectionViewDetailItem* _autoFillDetailItem;
 }
 
 // Stops observing browser state services. This is required during the shutdown
@@ -258,14 +260,14 @@ void SigninObserverBridge::GoogleSignedOut(const
std::string& account_id,
             _mainBrowserState);
     _syncObserverBridge.reset(new SyncObserverBridge(self, syncService));
 
-    _showMemoryDebugToolsEnabled.reset([[PrefBackedBoolean alloc]
+    _showMemoryDebugToolsEnabled = [[PrefBackedBoolean alloc]
         initWithPrefService:GetApplicationContext()->GetLocalState()
-                   prefName:prefs::kShowMemoryDebuggingTools]);
+                   prefName:prefs::kShowMemoryDebuggingTools];
     [_showMemoryDebugToolsEnabled setObserver:self];
 
     AuthenticationService* authService =
         AuthenticationServiceFactory::GetForBrowserState(_mainBrowserState);
-    _identity.reset([authService->GetAuthenticatedIdentity() retain]);
+    _identity = authService->GetAuthenticatedIdentity();
     _identityServiceObserver.reset(
         new ChromeIdentityServiceObserverBridge(self));
 
@@ -292,7 +294,6 @@ void SigninObserverBridge::GoogleSignedOut(const
std::string& account_id,
 
 - (void)dealloc {
   [self stopBrowserStateServiceObservers];
-  [super dealloc];
 }
 
 - (void)stopBrowserStateServiceObservers {
@@ -334,8 +335,8 @@ void SigninObserverBridge::GoogleSignedOut(const
std::string& account_id,
 
   // Basics section
   [model addSectionWithIdentifier:SectionIdentifierBasics];
-  CollectionViewTextItem* basicsHeader = [
-      [[CollectionViewTextItem alloc] initWithType:ItemTypeHeader]
autorelease];
+  CollectionViewTextItem* basicsHeader =
+      [[CollectionViewTextItem alloc] initWithType:ItemTypeHeader];
   basicsHeader.text =
l10n_util::GetNSString(IDS_IOS_OPTIONS_GENERAL_TAB_LABEL);
   basicsHeader.textColor = [[MDCPalette greyPalette] tint500];
   [model setHeader:basicsHeader
@@ -351,8 +352,8 @@ void SigninObserverBridge::GoogleSignedOut(const
std::string& account_id,
 
   // Advanced Section
   [model addSectionWithIdentifier:SectionIdentifierAdvanced];
-  CollectionViewTextItem* advancedHeader = [
-      [[CollectionViewTextItem alloc] initWithType:ItemTypeHeader]
autorelease];
+  CollectionViewTextItem* advancedHeader =
+      [[CollectionViewTextItem alloc] initWithType:ItemTypeHeader];
   advancedHeader.text =
       l10n_util::GetNSString(IDS_IOS_OPTIONS_ADVANCED_TAB_LABEL);
   advancedHeader.textColor = [[MDCPalette greyPalette] tint500];
@@ -375,8 +376,8 @@ void SigninObserverBridge::GoogleSignedOut(const
std::string& account_id,
   // Debug Section
   if ([self hasDebugSection]) {
     [model addSectionWithIdentifier:SectionIdentifierDebug];
-    CollectionViewTextItem* debugHeader = [[[CollectionViewTextItem alloc]
-        initWithType:ItemTypeHeader] autorelease];
+    CollectionViewTextItem* debugHeader =
+        [[CollectionViewTextItem alloc] initWithType:ItemTypeHeader];
     debugHeader.text = @"Debug";
     debugHeader.textColor = [[MDCPalette greyPalette] tint500];
     [model setHeader:debugHeader
@@ -384,7 +385,7 @@ void SigninObserverBridge::GoogleSignedOut(const
std::string& account_id,
   }
 
   if (experimental_flags::IsMemoryDebuggingEnabled()) {
-    _showMemoryDebugToolsItem.reset([[self showMemoryDebugSwitchItem] retain]);
+    _showMemoryDebugToolsItem = [self showMemoryDebugSwitchItem];
     [model addItem:_showMemoryDebugToolsItem
         toSectionWithIdentifier:SectionIdentifierDebug];
   }
@@ -413,12 +414,12 @@ void SigninObserverBridge::GoogleSignedOut(const
std::string& account_id,
       _hasRecordedSigninImpression = YES;
     }
     if (experimental_flags::IsSigninPromoEnabled()) {
-      _signinPromoViewMediator.reset([[SigninPromoViewMediator alloc] init]);
-      _signinPromoViewMediator.get().consumer = self;
+      _signinPromoViewMediator = [[SigninPromoViewMediator alloc] init];
+      _signinPromoViewMediator.consumer = self;
     }
     _signinSectionItem = [self signInTextItem];
   } else {
-    _signinPromoViewMediator.reset(nil);
+    _signinPromoViewMediator = nil;
     _signinSectionItem = [self accountCellItem];
   }
   return _signinSectionItem;
@@ -428,15 +429,15 @@ void SigninObserverBridge::GoogleSignedOut(const
std::string& account_id,
 
 - (CollectionViewItem*)signInTextItem {
   if (experimental_flags::IsSigninPromoEnabled()) {
-    DCHECK(_signinPromoViewMediator.get());
-    SigninPromoItem* signinPromoItem = [
-        [[SigninPromoItem alloc] initWithType:ItemTypeSigninPromo]
autorelease];
+    DCHECK(_signinPromoViewMediator);
+    SigninPromoItem* signinPromoItem =
+        [[SigninPromoItem alloc] initWithType:ItemTypeSigninPromo];
     signinPromoItem.configurator =
         [_signinPromoViewMediator createConfigurator];
     return signinPromoItem;
   }
-  AccountSignInItem* signInTextItem = [[[AccountSignInItem alloc]
-      initWithType:ItemTypeSignInButton] autorelease];
+  AccountSignInItem* signInTextItem =
+      [[AccountSignInItem alloc] initWithType:ItemTypeSignInButton];
   signInTextItem.accessibilityIdentifier = kSettingsSignInCellId;
 …
(message too large)

[stkhapugin, 2017-05-03 15:17:11]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-05-03 15:17:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2813223002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-03 15:17:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 15:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 15:21:35]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[stkhapugin, 2017-05-16 15:27:23]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[stkhapugin, 2017-05-16 15:27:50]

stkhapugin@chromium.org changed reviewers:
+ baxley@chromium.org

[stkhapugin, 2017-05-16 15:27:51]

+baxley for owners of EG build.gn

[commit-bot: I haz the power, 2017-05-16 15:28:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[baxley, 2017-05-16 15:49:53]

ios/chrome/test/earl_grey/ LGTM

[commit-bot: I haz the power, 2017-05-16 20:27:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 20:27:15]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-05-17 11:47:46]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-05-17 11:47:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2813223002/#ps120001
(title: "reabse")

[commit-bot: I haz the power, 2017-05-17 11:47:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 11:52:57]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495021666848790,
"parent_rev": "ae9de50e595b29c947d00c8f652e8ac3ab41f768", "commit_rev":
"659885eebc27bf7a49b806d2f8b104b547b36605"}

[commit-bot: I haz the power, 2017-05-17 11:53:10]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/settings:settings to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2813223002
Cr-Commit-Position: refs/heads/master@{#472426}
Committed:
https://chromium.googlesource.com/chromium/src/+/659885eebc27bf7a49b806d2f8b1...
==========

[commit-bot: I haz the power, 2017-05-17 11:53:11]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/659885eebc27bf7a49b806d2f8b1...

[lpromero, 2017-06-15 08:31:49]

https://codereview.chromium.org/2813223002/diff/120001/ios/chrome/browser/ui/...
File
ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm
(right):

https://codereview.chromium.org/2813223002/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm:434:
self.navigationItem.leftBarButtonItem = savedLeftButton_ = nil;
Wow. That's a bad one (idem below). We should make a pass on the entire code
base to see if this happened somewhere else.