Web Animations: Coalesce constructors where possible.

Web Animations: Coalesce constructors where possible.

ElementAnimation.idl, KeyframeEffect.idl and KeyframeEffectReadOnly.idl were
specifying two constructors to deal with the fact that, at some point, union
types did not support dictionary type members.

This is no longer the case, so we can have a single constructor that matches
the IDLs in the Web Animations spec instead (in ElementAnimation's case, we
also move from "double" to "unrestricted double" to match the spec).

We achieve this by using the UnrestrictedDoubleOrKeyframeEffectOptions union
type (which works just fine) and leaving it up to TimingInput to process
each possible type accordingly.

BUG=624639
R=alancutter@chromium.org,dstockwell@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2814523002
Cr-Commit-Position: refs/heads/master@{#463987}
Committed: https://chromium.googlesource.com/chromium/src/+/3a9d689cfc759f63f6d113cde80efa9801125c3c

[Raphael Kubo da Costa (rakuco), 2017-04-10 16:13:48]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 16:14:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raphael Kubo da Costa (rakuco), 2017-04-10 17:18:32]

PTAL
alancutter, dstockwell for the actual animation bits.
haraken for the build system change.

[commit-bot: I haz the power, 2017-04-10 18:56:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 18:56:34]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-04-11 00:07:27]

LGTM

[alancutter (OOO until 2018), 2017-04-12 05:17:56]

lgtm, nice!

[Raphael Kubo da Costa (rakuco), 2017-04-12 07:14:30]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-04-12 07:14:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 07:16:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 07:16:52]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Raphael Kubo da Costa (rakuco), 2017-04-12 07:23:36]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[Raphael Kubo da Costa (rakuco), 2017-04-12 07:23:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2814523002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-12 07:24:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 10:48:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491981816186480,
"parent_rev": "76798dbd04a30a8e1acdf71ecab93d09dac4ec5b", "commit_rev":
"3a9d689cfc759f63f6d113cde80efa9801125c3c"}

[commit-bot: I haz the power, 2017-04-12 10:49:02]

Description was changed from

==========
Web Animations: Coalesce constructors where possible.

ElementAnimation.idl, KeyframeEffect.idl and KeyframeEffectReadOnly.idl were
specifying two constructors to deal with the fact that, at some point, union
types did not support dictionary type members.

This is no longer the case, so we can have a single constructor that matches
the IDLs in the Web Animations spec instead (in ElementAnimation's case, we
also move from "double" to "unrestricted double" to match the spec).

We achieve this by using the UnrestrictedDoubleOrKeyframeEffectOptions union
type (which works just fine) and leaving it up to TimingInput to process
each possible type accordingly.

BUG=624639
R=alancutter@chromium.org,dstockwell@chromium.org,haraken@chromium.org
==========

to

==========
Web Animations: Coalesce constructors where possible.

ElementAnimation.idl, KeyframeEffect.idl and KeyframeEffectReadOnly.idl were
specifying two constructors to deal with the fact that, at some point, union
types did not support dictionary type members.

This is no longer the case, so we can have a single constructor that matches
the IDLs in the Web Animations spec instead (in ElementAnimation's case, we
also move from "double" to "unrestricted double" to match the spec).

We achieve this by using the UnrestrictedDoubleOrKeyframeEffectOptions union
type (which works just fine) and leaving it up to TimingInput to process
each possible type accordingly.

BUG=624639
R=alancutter@chromium.org,dstockwell@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2814523002
Cr-Commit-Position: refs/heads/master@{#463987}
Committed:
https://chromium.googlesource.com/chromium/src/+/3a9d689cfc759f63f6d113cde80e...
==========

[commit-bot: I haz the power, 2017-04-12 10:49:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3a9d689cfc759f63f6d113cde80e...