third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl - Issue 2814523002: Web Animations: Coalesce constructors where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl

Issue 2814523002: Web Animations: Coalesce constructors where possible. (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp ('k') | third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl b/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl

index f270b2b5e27a840f782944b10bd85b9f2fb0ce03..c4d024f2c4cd34e7ae6052412769fc01a41382b3 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl

@@ -5,9 +5,7 @@

// https://w3c.github.io/web-animations/#the-keyframeeffect-interfaces

[

- // TODO(dstockwell): the third argument should be "optional (unrestricted double or KeyframeEffectOptions) timing".

- Constructor(Element? target, (sequence<Dictionary> or Dictionary)? effect, optional unrestricted double timing),

- Constructor(Element? target, (sequence<Dictionary> or Dictionary)? effect, KeyframeEffectOptions timing),

+ Constructor(Element? target, (sequence<Dictionary> or Dictionary)? effect, optional (unrestricted double or KeyframeEffectOptions) options),

ConstructorCallWith=ExecutionContext,

RaisesException=Constructor,

RuntimeEnabled=WebAnimationsAPI,