third_party/WebKit/Source/core/animation/ElementAnimation.idl - Issue 2814523002: Web Animations: Coalesce constructors where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/ElementAnimation.idl

Issue 2814523002: Web Animations: Coalesce constructors where possible. (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/ElementAnimation.h ('k') | third_party/WebKit/Source/core/animation/KeyframeEffect.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/ElementAnimation.idl

diff --git a/third_party/WebKit/Source/core/animation/ElementAnimation.idl b/third_party/WebKit/Source/core/animation/ElementAnimation.idl

index d66c98b4f7cf7e3629c4446626dc102db34b59ec..018a7afdfe319990b46f8940bf2b2322aa421a35 100644

--- a/third_party/WebKit/Source/core/animation/ElementAnimation.idl

+++ b/third_party/WebKit/Source/core/animation/ElementAnimation.idl

@@ -36,9 +36,6 @@

// https://w3c.github.io/web-animations/#the-animatable-interface

partial interface Element {

- // FIXME: Union types with dictionary type members doesn't work (yet).

- // Animation animate((sequence<Dictionary> or Dictionary)? effect, optional (double or KeyframeEffectOptions) timing);

- [CallWith=ScriptState, Measure, RaisesException] Animation animate((sequence<Dictionary> or Dictionary)? effect, optional double timing);

- [CallWith=ScriptState, Measure, RaisesException] Animation animate((sequence<Dictionary> or Dictionary)? effect, KeyframeEffectOptions timing);

+ [CallWith=ScriptState, Measure, RaisesException] Animation animate((sequence<Dictionary> or Dictionary)? effect, optional (unrestricted double or KeyframeEffectOptions) options);

[RuntimeEnabled=WebAnimationsAPI] sequence<Animation> getAnimations();

};