Web Animations: Coalesce constructors where possible.

third_party/WebKit/Source/core/animation/ElementAnimation.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef ElementAnimation_h
 #define ElementAnimation_h
 
 #include "bindings/core/v8/DictionarySequenceOrDictionary.h"
 #include "bindings/core/v8/ScriptState.h"
+#include "bindings/core/v8/UnrestrictedDoubleOrKeyframeEffectOptions.h"
 #include "core/animation/DocumentTimeline.h"
 #include "core/animation/EffectInput.h"
 #include "core/animation/ElementAnimations.h"
 #include "core/animation/KeyframeEffect.h"
-#include "core/animation/KeyframeEffectOptions.h"
 #include "core/animation/KeyframeEffectReadOnly.h"
 #include "core/animation/TimingInput.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/ExecutionContext.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/wtf/Allocator.h"
 
 namespace blink {
 
 class ElementAnimation {
   STATIC_ONLY(ElementAnimation);
 
  public:
   static Animation* animate(ScriptState* script_state,
                             Element& element,
                             const DictionarySequenceOrDictionary& effect_input,
-                            double duration,
+                            UnrestrictedDoubleOrKeyframeEffectOptions options,
                             ExceptionState& exception_state) {
     EffectModel* effect = EffectInput::Convert(
         &element, effect_input, ExecutionContext::From(script_state),
-        exception_state);
-    if (exception_state.HadException())
-      return nullptr;
-
-    Timing timing;
-    if (!TimingInput::Convert(duration, timing, exception_state))
-      return nullptr;
-
-    return animate(element, effect, timing);
-  }
-
-  static Animation* animate(ScriptState* script_state,
-                            Element& element,
-                            const DictionarySequenceOrDictionary& effect_input,
-                            const KeyframeEffectOptions& options,
-                            ExceptionState& exception_state) {
-    EffectModel* effect = EffectInput::Convert(
-        &element, effect_input, ExecutionContext::From(script_state),
         exception_state);
     if (exception_state.HadException())
       return nullptr;
 
     Timing timing;
     if (!TimingInput::Convert(options, timing, &element.GetDocument(),
                               exception_state))
       return nullptr;
 
-    Animation* animation = animate(element, effect, timing);
-    animation->setId(options.id());
-    return animation;
+    if (options.isKeyframeEffectOptions()) {
+      Animation* animation = animate(element, effect, timing);
+      animation->setId(options.getAsKeyframeEffectOptions().id());
+      return animation;
+    }
+    return animate(element, effect, timing);
   }
 
   static Animation* animate(ScriptState* script_state,
                             Element& element,
                             const DictionarySequenceOrDictionary& effect_input,
                             ExceptionState& exception_state) {
     EffectModel* effect = EffectInput::Convert(
         &element, effect_input, ExecutionContext::From(script_state),
         exception_state);
     if (exception_state.HadException())
@@ skipping 23 matching lines @@
            animation->effect()->IsInEffect()))
         animations.push_back(animation);
     }
     return animations;
   }
 };
 
 }  // namespace blink
 
 #endif  // ElementAnimation_h