third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl - Issue 2814523002: Web Animations: Coalesce constructors where possible.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl

Issue 2814523002: Web Animations: Coalesce constructors where possible. (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/web-animations/#the-keyframeeffect-interfaces	5 // https://w3c.github.io/web-animations/#the-keyframeeffect-interfaces

6	6

7 [	7 [

8 // TODO(dstockwell): the third argument should be "optional (unrestricted do uble or KeyframeEffectOptions) timing".	8 Constructor(Element? target, (sequence<Dictionary> or Dictionary)? effect, o ptional (unrestricted double or KeyframeEffectOptions) options),

9 Constructor(Element? target, (sequence<Dictionary> or Dictionary)? effect, o ptional unrestricted double timing),

10 Constructor(Element? target, (sequence<Dictionary> or Dictionary)? effect, K eyframeEffectOptions timing),

11 ConstructorCallWith=ExecutionContext,	9 ConstructorCallWith=ExecutionContext,

12 RaisesException=Constructor,	10 RaisesException=Constructor,

13 RuntimeEnabled=WebAnimationsAPI,	11 RuntimeEnabled=WebAnimationsAPI,

14 ] interface KeyframeEffectReadOnly : AnimationEffectReadOnly {	12 ] interface KeyframeEffectReadOnly : AnimationEffectReadOnly {

15 };	13 };

OLD	NEW