Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy

Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy

For cleanup, this CL replaces WorkerLoaderProxy's PostTask functions with
WebTaskRunner.

Following CLs will more clean up or remove WorkerLoaderProxy.

BUG=694914
Review-Url: https://codereview.chromium.org/2811993007
Cr-Commit-Position: refs/heads/master@{#466300}
Committed: https://chromium.googlesource.com/chromium/src/+/156f6edd319292215ac0d8a72863cf4ae6cded7e

[nhiroki, 2017-04-14 02:05:43]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 02:06:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-14 05:03:30]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 05:03:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-14 05:06:04]

Description was changed from

==========
Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy

BUG=
==========

to

==========
Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy

For cleanup, this CL replaces WorkerLoaderProxy's PostTask functions with
WebTaskRunner.

Following CLs will more clean up or remove WorkerLoaderProxy.

BUG=
==========

[nhiroki, 2017-04-14 05:17:38]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-14 06:44:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 06:44:52]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-04-21 04:48:40]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 04:49:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-21 05:36:17]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2017-04-21 05:36:25]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2017-04-21 05:36:35]

Patchset #1 (id:60001) has been deleted

[nhiroki, 2017-04-21 05:36:38]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[nhiroki, 2017-04-21 05:36:56]

Description was changed from

==========
Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy

For cleanup, this CL replaces WorkerLoaderProxy's PostTask functions with
WebTaskRunner.

Following CLs will more clean up or remove WorkerLoaderProxy.

BUG=
==========

to

==========
Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy

For cleanup, this CL replaces WorkerLoaderProxy's PostTask functions with
WebTaskRunner.

Following CLs will more clean up or remove WorkerLoaderProxy.

BUG=694914
==========

[commit-bot: I haz the power, 2017-04-21 05:37:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-21 05:37:54]

nhiroki@chromium.org changed reviewers:
+ kinuko@chromium.org, yhirano@chromium.org

[nhiroki, 2017-04-21 05:37:55]

PTAL, thanks!

[kinuko, 2017-04-21 06:05:10]

lgtm

https://codereview.chromium.org/2811993007/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h (right):

https://codereview.chromium.org/2811993007/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h:49: //
WorkerLoaderProxy object have been dropped.
This is now more about ThreadableLoadingContextProvider (and it's getting
unclear if we really need this class), but I assume you're making followup CLs

(Would you put a TODO to clean up this class further?)

https://codereview.chromium.org/2811993007/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/2811993007/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp:244: //
WorkerLoaderProxyProvider -------------------------------------------------
Let's remove this comment too

[commit-bot: I haz the power, 2017-04-21 07:15:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 07:15:09]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-04-21 08:45:29]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 08:45:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-21 08:46:01]

Thank you!

https://codereview.chromium.org/2811993007/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h (right):

https://codereview.chromium.org/2811993007/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h:49: //
WorkerLoaderProxy object have been dropped.
On 2017/04/21 06:05:10, kinuko wrote:
> This is now more about ThreadableLoadingContextProvider (and it's getting
> unclear if we really need this class), but I assume you're making followup CLs

Yes! I'll make them.

> (Would you put a TODO to clean up this class further?)

Done.

https://codereview.chromium.org/2811993007/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/2811993007/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp:244: //
WorkerLoaderProxyProvider -------------------------------------------------
On 2017/04/21 06:05:10, kinuko wrote:
> Let's remove this comment too

Done.

[yhirano, 2017-04-21 09:06:49]

lgtm

[nhiroki, 2017-04-21 09:07:03]

The CQ bit was unchecked by nhiroki@chromium.org

[nhiroki, 2017-04-21 09:07:06]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-04-21 09:07:07]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2811993007/#ps100001
(title: "address review comments")

[commit-bot: I haz the power, 2017-04-21 09:07:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-04-21 09:48:49]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-04-21 09:48:50]

LGTM

https://codereview.chromium.org/2811993007/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp
(right):

https://codereview.chromium.org/2811993007/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp:62:
TaskRunnerHelper::Get(TaskType::kMiscPlatformAPI, GetWorkerThread())

I'm not sure if this is a speced task though.

https://codereview.chromium.org/2811993007/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h (right):

https://codereview.chromium.org/2811993007/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h:45: // The abstract
interface to provider ThreadableLoadingContext; separated from

provide

https://codereview.chromium.org/2811993007/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h:47: // protected
reference to the provider object. This to support non-overlapping

This is to

[commit-bot: I haz the power, 2017-04-21 10:16:52]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1492765626789260,
"parent_rev": "b92e7bbc8617e7b0a7c0e24f800457a51c420209", "commit_rev":
"156f6edd319292215ac0d8a72863cf4ae6cded7e"}

[commit-bot: I haz the power, 2017-04-21 10:17:11]

Description was changed from

==========
Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy

For cleanup, this CL replaces WorkerLoaderProxy's PostTask functions with
WebTaskRunner.

Following CLs will more clean up or remove WorkerLoaderProxy.

BUG=694914
==========

to

==========
Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy

For cleanup, this CL replaces WorkerLoaderProxy's PostTask functions with
WebTaskRunner.

Following CLs will more clean up or remove WorkerLoaderProxy.

BUG=694914

Review-Url: https://codereview.chromium.org/2811993007
Cr-Commit-Position: refs/heads/master@{#466300}
Committed:
https://chromium.googlesource.com/chromium/src/+/156f6edd319292215ac0d8a72863...
==========

[commit-bot: I haz the power, 2017-04-21 10:17:13]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/156f6edd319292215ac0d8a72863...