Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.h

Issue 2811993007: Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy (Closed)
Patch Set: address review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebSharedWorkerImpl.h
diff --git a/third_party/WebKit/Source/web/WebSharedWorkerImpl.h b/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
index dbe067dffe6a645d5f03e4c25cd3b89370eb9c83..85ea4b47391b9cc3b1b259a9b9ddd5cbfb2e2990 100644
--- a/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
+++ b/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
@@ -47,7 +47,6 @@
namespace blink {
-class ParentFrameTaskRunners;
class WebApplicationCacheHost;
class WebApplicationCacheHostClient;
class WebLocalFrameImpl;
@@ -128,12 +127,6 @@ class WebSharedWorkerImpl final : public WebFrameClient,
void ConnectTaskOnWorkerThread(std::unique_ptr<WebMessagePortChannel>);
// WorkerLoaderProxyProvider
- // postTaskToLoader() must be called from a worker thread.
- void PostTaskToLoader(const WebTraceLocation&,
- std::unique_ptr<WTF::CrossThreadClosure>) override;
- void PostTaskToWorkerGlobalScope(
- const WebTraceLocation&,
- std::unique_ptr<WTF::CrossThreadClosure>) override;
ThreadableLoadingContext* GetThreadableLoadingContext() override;
// 'shadow page' - created to proxy loading requests from the worker.
@@ -148,9 +141,6 @@ class WebSharedWorkerImpl final : public WebFrameClient,
Persistent<WorkerInspectorProxy> worker_inspector_proxy_;
- // Owned by the main thread, but will be accessed by the worker.
- CrossThreadPersistent<ParentFrameTaskRunners> parent_frame_task_runners_;
-
Persistent<WebSharedWorkerReportingProxyImpl> reporting_proxy_;
std::unique_ptr<WorkerThread> worker_thread_;

Powered by Google App Engine
This is Rietveld 408576698