Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h

Issue 2811993007: Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy (Closed)
Patch Set: address review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h b/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
index b0e58710edcdf9e61fe0dc4780e5840bf2e7bcb0..d646ffd3a047bfa609d83bc2aaa182795475393a 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
+++ b/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
@@ -35,28 +35,6 @@
namespace blink {
-class MockWorkerLoaderProxyProvider : public WorkerLoaderProxyProvider {
- public:
- MockWorkerLoaderProxyProvider() {}
- ~MockWorkerLoaderProxyProvider() override {}
-
- void PostTaskToLoader(const WebTraceLocation&,
- std::unique_ptr<WTF::CrossThreadClosure>) override {
- NOTIMPLEMENTED();
- }
-
- void PostTaskToWorkerGlobalScope(
- const WebTraceLocation&,
- std::unique_ptr<WTF::CrossThreadClosure>) override {
- NOTIMPLEMENTED();
- }
-
- ThreadableLoadingContext* GetThreadableLoadingContext() override {
- NOTIMPLEMENTED();
- return nullptr;
- }
-};
-
class MockWorkerThreadLifecycleObserver final
: public GarbageCollectedFinalized<MockWorkerThreadLifecycleObserver>,
public WorkerThreadLifecycleObserver {
@@ -73,12 +51,10 @@ class MockWorkerThreadLifecycleObserver final
class WorkerThreadForTest : public WorkerThread {
public:
- WorkerThreadForTest(
- WorkerLoaderProxyProvider* mock_worker_loader_proxy_provider,
- WorkerReportingProxy& mock_worker_reporting_proxy)
- : WorkerThread(
- WorkerLoaderProxy::Create(mock_worker_loader_proxy_provider),
- mock_worker_reporting_proxy),
+ WorkerThreadForTest(WorkerLoaderProxyProvider* worker_loader_proxy_provider,
+ WorkerReportingProxy& mock_worker_reporting_proxy)
+ : WorkerThread(WorkerLoaderProxy::Create(worker_loader_proxy_provider),
+ mock_worker_reporting_proxy),
worker_backing_thread_(
WorkerBackingThread::CreateForTest("Test thread")) {}

Powered by Google App Engine
This is Rietveld 408576698