Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp

Issue 2811993007: Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy (Closed)
Patch Set: address review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
diff --git a/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp b/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
index 4842fbce89be2cfbdfbe6d21a0d3fd71793a3dd9..1da848b7ada3299d60be9533e1d895b881dc7515 100644
--- a/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
+++ b/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
@@ -92,10 +92,10 @@ class InProcessWorkerMessagingProxyForTest
WorkerObjectProxy().next_interval_in_sec_ = kNextIntervalInSec;
WorkerObjectProxy().max_interval_in_sec_ = kMaxIntervalInSec;
- mock_worker_loader_proxy_provider_ =
- WTF::MakeUnique<MockWorkerLoaderProxyProvider>();
+ worker_loader_proxy_provider_ =
+ WTF::MakeUnique<WorkerLoaderProxyProvider>();
worker_thread_ = WTF::WrapUnique(new DedicatedWorkerThreadForTest(
- mock_worker_loader_proxy_provider_.get(), WorkerObjectProxy()));
+ worker_loader_proxy_provider_.get(), WorkerObjectProxy()));
mock_worker_thread_lifecycle_observer_ =
new MockWorkerThreadLifecycleObserver(
worker_thread_->GetWorkerThreadLifecycleContext());
@@ -107,7 +107,7 @@ class InProcessWorkerMessagingProxyForTest
~InProcessWorkerMessagingProxyForTest() override {
EXPECT_FALSE(blocking_);
worker_thread_->GetWorkerLoaderProxy()->DetachProvider(
- mock_worker_loader_proxy_provider_.get());
+ worker_loader_proxy_provider_.get());
}
void StartWithSourceCode(const String& source) {
@@ -192,8 +192,7 @@ class InProcessWorkerMessagingProxyForTest
}
private:
- std::unique_ptr<MockWorkerLoaderProxyProvider>
- mock_worker_loader_proxy_provider_;
+ std::unique_ptr<WorkerLoaderProxyProvider> worker_loader_proxy_provider_;
Persistent<MockWorkerThreadLifecycleObserver>
mock_worker_thread_lifecycle_observer_;
RefPtr<SecurityOrigin> security_origin_;

Powered by Google App Engine
This is Rietveld 408576698