third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h - Issue 2811993007: Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h

Issue 2811993007: Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy (Closed)

Patch Set: address review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp ('k') | third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp » ('j') | third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h

diff --git a/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h b/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h

index a6a31d10688a98e4a91bea5f4348a552f7d71346..ed21b16a9ac067aed4eec52b8a1ec64c7a23cec4 100644

--- a/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h

+++ b/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h

@@ -80,13 +80,6 @@ class CORE_EXPORT ThreadedMessagingProxyBase

bool IsParentContextThread() const;

// WorkerLoaderProxyProvider

- // These methods are called on different threads to schedule loading

- // requests and to send callbacks back to WorkerGlobalScope.

- void PostTaskToLoader(const WebTraceLocation&,

- std::unique_ptr<WTF::CrossThreadClosure>) override;

- void PostTaskToWorkerGlobalScope(

- const WebTraceLocation&,

- std::unique_ptr<WTF::CrossThreadClosure>) override;

ThreadableLoadingContext* GetThreadableLoadingContext() override;

private: