Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)

Created:
3 years, 8 months ago by Hwanseung Lee
Modified:
3 years, 8 months ago
Reviewers:
tkent, eae
CC:
blink-reviews, chromium-reviews, kinuko+watch, leviw+bidiwatch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/platform/text. BUG=707660 Review-Url: https://codereview.chromium.org/2811453002 Cr-Commit-Position: refs/heads/master@{#463569} Committed: https://chromium.googlesource.com/chromium/src/+/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5

Patch Set 1 #

Patch Set 2 : Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text #

Total comments: 24

Patch Set 3 : test #

Total comments: 6

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -144 lines) Patch
M third_party/WebKit/Source/platform/text/BidiCharacterRun.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/BidiContext.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/BidiContext.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolver.h View 1 2 13 chunks +23 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolverTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/BidiRunList.h View 1 2 6 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/text/Character.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/CharacterEmoji.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/DateTimeFormat.cpp View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleICU.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleMac.mm View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleWin.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/text/PlatformLocale.cpp View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/text/SegmentedString.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/text/SegmentedString.cpp View 1 2 7 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/text/StringTruncator.cpp View 1 2 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/text/SuffixTree.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIterator.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp View 1 2 3 24 chunks +30 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextRun.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp View 1 2 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 62 (50 generated)
Hwanseung Lee
PTAL, thank you.
3 years, 8 months ago (2017-04-08 10:04:34 UTC) #26
eae
LGTM Thank you
3 years, 8 months ago (2017-04-09 07:32:02 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811453002/80001
3 years, 8 months ago (2017-04-09 08:16:53 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/401154)
3 years, 8 months ago (2017-04-09 10:07:08 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811453002/80001
3 years, 8 months ago (2017-04-09 11:08:56 UTC) #37
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/platform/text/BidiCharacterRun.h: While running git apply --index -3 -p1; error: patch ...
3 years, 8 months ago (2017-04-09 22:05:11 UTC) #39
tkent
https://codereview.chromium.org/2811453002/diff/80001/third_party/WebKit/Source/platform/text/BidiContext.h File third_party/WebKit/Source/platform/text/BidiContext.h (right): https://codereview.chromium.org/2811453002/diff/80001/third_party/WebKit/Source/platform/text/BidiContext.h#newcode74 third_party/WebKit/Source/platform/text/BidiContext.h:74: DCHECK(level <= kMaxLevel); Use DCHECK_LE if it doesn't cause ...
3 years, 8 months ago (2017-04-09 23:07:02 UTC) #40
Hwanseung Lee
tkent@ PTAL, thank you. https://codereview.chromium.org/2811453002/diff/80001/third_party/WebKit/Source/platform/text/BidiContext.h File third_party/WebKit/Source/platform/text/BidiContext.h (right): https://codereview.chromium.org/2811453002/diff/80001/third_party/WebKit/Source/platform/text/BidiContext.h#newcode74 third_party/WebKit/Source/platform/text/BidiContext.h:74: DCHECK(level <= kMaxLevel); On 2017/04/09 ...
3 years, 8 months ago (2017-04-11 03:29:39 UTC) #50
tkent
lgtm with comments https://codereview.chromium.org/2811453002/diff/110001/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp File third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp (right): https://codereview.chromium.org/2811453002/diff/110001/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp#newcode243 third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp:243: DCHECK(length <= std::numeric_limits<int32_t>::max()); Use DCHECK_LE https://codereview.chromium.org/2811453002/diff/110001/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp#newcode281 ...
3 years, 8 months ago (2017-04-11 03:38:56 UTC) #51
Hwanseung Lee
https://codereview.chromium.org/2811453002/diff/110001/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp File third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp (right): https://codereview.chromium.org/2811453002/diff/110001/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp#newcode243 third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp:243: DCHECK(length <= std::numeric_limits<int32_t>::max()); On 2017/04/11 03:38:56, tkent wrote: > ...
3 years, 8 months ago (2017-04-11 07:49:09 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811453002/130001
3 years, 8 months ago (2017-04-11 07:49:33 UTC) #59
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 07:56:06 UTC) #62
Message was sent while issue was closed.
Committed patchset #4 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/28d7e2fdd0bb11a7d0061b60ee16...

Powered by Google App Engine
This is Rietveld 408576698