third_party/WebKit/Source/platform/text/BidiResolverTest.cpp - Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/BidiResolverTest.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)

Patch Set: fix Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/BidiResolverTest.cpp

diff --git a/third_party/WebKit/Source/platform/text/BidiResolverTest.cpp b/third_party/WebKit/Source/platform/text/BidiResolverTest.cpp

index ccc086173759d29df26ec733026dba519b884664..62eea87d7d9332a11e74781b8baa3a849f9f0b9f 100644

--- a/third_party/WebKit/Source/platform/text/BidiResolverTest.cpp

+++ b/third_party/WebKit/Source/platform/text/BidiResolverTest.cpp

@@ -216,7 +216,7 @@ void BidiTestRunner::RunTest(const std::basic_string<UChar>& input,

// Blink's UBA just makes runs, the actual ordering of the display of

// characters is handled later in our pipeline, so we fake it here:

bool reversed = run->Reversed(false);

- ASSERT(run->Stop() >= run->Start());

+ DCHECK_GE(run->Stop(), run->Start());

size_t length = run->Stop() - run->Start();

for (size_t i = 0; i < length; i++) {

int input_index = reversed ? run->Stop() - i - 1 : run->Start() + i;