Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: third_party/WebKit/Source/platform/text/LocaleWin.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/LocaleWin.cpp
diff --git a/third_party/WebKit/Source/platform/text/LocaleWin.cpp b/third_party/WebKit/Source/platform/text/LocaleWin.cpp
index 6926e943baf2a3d18ac4926206f3a297fe0d5e76..d1912a7c8ec9ad7e3b3f98206f01092a6772e530 100644
--- a/third_party/WebKit/Source/platform/text/LocaleWin.cpp
+++ b/third_party/WebKit/Source/platform/text/LocaleWin.cpp
@@ -207,7 +207,7 @@ static String ConvertWindowsDateTimeFormat(const String& format) {
if (in_quote) {
if (ch == '\'') {
in_quote = false;
- ASSERT(i);
+ DCHECK(i);
if (last_quote_can_be_literal && format[i - 1] == '\'') {
literal_buffer.Append('\'');
last_quote_can_be_literal = false;
@@ -451,15 +451,15 @@ void LocaleWin::InitializeLocaleData() {
symbols.push_back("9");
} else {
String digits = GetLocaleInfoString(LOCALE_SNATIVEDIGITS);
- ASSERT(digits.length() >= 10);
+ DCHECK_GE(digits.length(), 10u);
for (unsigned i = 0; i < 10; ++i)
symbols.push_back(digits.Substring(i, 1));
}
- ASSERT(symbols.size() == kDecimalSeparatorIndex);
+ DCHECK(symbols.size() == kDecimalSeparatorIndex);
symbols.push_back(GetLocaleInfoString(LOCALE_SDECIMAL));
- ASSERT(symbols.size() == kGroupSeparatorIndex);
+ DCHECK(symbols.size() == kGroupSeparatorIndex);
symbols.push_back(GetLocaleInfoString(LOCALE_STHOUSAND));
- ASSERT(symbols.size() == kDecimalSymbolsSize);
+ DCHECK(symbols.size() == kDecimalSymbolsSize);
String negative_sign = GetLocaleInfoString(LOCALE_SNEGATIVESIGN);
enum NegativeFormat {
« no previous file with comments | « third_party/WebKit/Source/platform/text/LocaleMac.mm ('k') | third_party/WebKit/Source/platform/text/PlatformLocale.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698