Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: third_party/WebKit/Source/platform/text/SegmentedString.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/SegmentedString.cpp
diff --git a/third_party/WebKit/Source/platform/text/SegmentedString.cpp b/third_party/WebKit/Source/platform/text/SegmentedString.cpp
index 2f58754937ce5811d1545776dab227defc6b7e99..cd2507a2696488b1f588262c75392dbbf99bfb1e 100644
--- a/third_party/WebKit/Source/platform/text/SegmentedString.cpp
+++ b/third_party/WebKit/Source/platform/text/SegmentedString.cpp
@@ -57,7 +57,7 @@ void SegmentedString::Clear() {
}
void SegmentedString::Append(const SegmentedSubstring& s) {
- ASSERT(!closed_);
+ DCHECK(!closed_);
if (!s.length())
return;
@@ -73,7 +73,7 @@ void SegmentedString::Append(const SegmentedSubstring& s) {
}
void SegmentedString::Push(UChar c) {
- ASSERT(c);
+ DCHECK(c);
// pushIfPossible attempts to rewind the pointer in the SegmentedSubstring,
// however it will fail if the SegmentedSubstring is empty, or
@@ -88,7 +88,7 @@ void SegmentedString::Push(UChar c) {
}
void SegmentedString::Prepend(const SegmentedSubstring& s, PrependType type) {
- ASSERT(!s.NumberOfCharactersConsumed());
+ DCHECK(!s.NumberOfCharactersConsumed());
if (!s.length())
return;
@@ -113,12 +113,12 @@ void SegmentedString::Prepend(const SegmentedSubstring& s, PrependType type) {
void SegmentedString::Close() {
// Closing a stream twice is likely a coding mistake.
- ASSERT(!closed_);
+ DCHECK(!closed_);
closed_ = true;
}
void SegmentedString::Append(const SegmentedString& s) {
- ASSERT(!closed_);
+ DCHECK(!closed_);
Append(s.current_string_);
if (s.IsComposite()) {
@@ -195,7 +195,7 @@ void SegmentedString::Advance16() {
}
void SegmentedString::AdvanceAndUpdateLineNumber8() {
- ASSERT(current_string_.GetCurrentChar() == current_char_);
+ DCHECK_EQ(current_string_.GetCurrentChar(), current_char_);
if (current_char_ == '\n') {
++current_line_;
number_of_characters_consumed_prior_to_current_line_ =
@@ -206,7 +206,7 @@ void SegmentedString::AdvanceAndUpdateLineNumber8() {
}
void SegmentedString::AdvanceAndUpdateLineNumber16() {
- ASSERT(current_string_.GetCurrentChar() == current_char_);
+ DCHECK_EQ(current_string_.GetCurrentChar(), current_char_);
if (current_char_ == '\n') {
++current_line_;
number_of_characters_consumed_prior_to_current_line_ =
@@ -260,7 +260,8 @@ void SegmentedString::AdvanceAndUpdateLineNumberSlowCase() {
}
void SegmentedString::AdvanceEmpty() {
- ASSERT(!current_string_.length() && !IsComposite());
+ DCHECK(!current_string_.length());
+ DCHECK(!IsComposite());
current_char_ = 0;
}
« no previous file with comments | « third_party/WebKit/Source/platform/text/SegmentedString.h ('k') | third_party/WebKit/Source/platform/text/StringTruncator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698