Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: third_party/WebKit/Source/platform/text/BidiContext.h

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2006, 2007, 2009, 2010 Apple Inc. 3 * Copyright (C) 2003, 2004, 2006, 2007, 2009, 2010 Apple Inc.
4 * All right reserved. 4 * All right reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 BidiContext(unsigned char level, 64 BidiContext(unsigned char level,
65 WTF::Unicode::CharDirection direction, 65 WTF::Unicode::CharDirection direction,
66 bool override, 66 bool override,
67 BidiEmbeddingSource source, 67 BidiEmbeddingSource source,
68 BidiContext* parent) 68 BidiContext* parent)
69 : m_level(level), 69 : m_level(level),
70 m_direction(direction), 70 m_direction(direction),
71 m_override(override), 71 m_override(override),
72 m_source(source), 72 m_source(source),
73 m_parent(parent) { 73 m_parent(parent) {
74 ASSERT(level <= kMaxLevel); 74 DCHECK(level <= kMaxLevel);
tkent 2017/04/09 23:07:01 Use DCHECK_LE if it doesn't cause a compile failur
Hwanseung Lee 2017/04/11 03:29:38 it was cause a compile failure.
75 } 75 }
76 76
77 static PassRefPtr<BidiContext> createUncached(unsigned char level, 77 static PassRefPtr<BidiContext> createUncached(unsigned char level,
78 WTF::Unicode::CharDirection, 78 WTF::Unicode::CharDirection,
79 bool override, 79 bool override,
80 BidiEmbeddingSource, 80 BidiEmbeddingSource,
81 BidiContext* parent); 81 BidiContext* parent);
82 82
83 // The maximium bidi level is 125: 83 // The maximium bidi level is 125:
84 // http://unicode.org/reports/tr9/#Explicit_Levels_and_Directions 84 // http://unicode.org/reports/tr9/#Explicit_Levels_and_Directions
(...skipping 10 matching lines...) Expand all
95 95
96 inline unsigned char nextGreaterEvenLevel(unsigned char level) { 96 inline unsigned char nextGreaterEvenLevel(unsigned char level) {
97 return (level + 2) & ~1; 97 return (level + 2) & ~1;
98 } 98 }
99 99
100 PLATFORM_EXPORT bool operator==(const BidiContext&, const BidiContext&); 100 PLATFORM_EXPORT bool operator==(const BidiContext&, const BidiContext&);
101 101
102 } // namespace blink 102 } // namespace blink
103 103
104 #endif // BidiContext_h 104 #endif // BidiContext_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698