Fix the settings button and UMA metrics for the message center

Fix the settings button and UMA metrics for the message center

The settings button was unintentionally broken for Windows and
Linux users in 2799653004, as was gathering of some UMA. This
CL offers a slight refactoring that meets all goals.

BUG=706658
Review-Url: https://codereview.chromium.org/2807623002
Cr-Commit-Position: refs/heads/master@{#463339}
Committed: https://chromium.googlesource.com/chromium/src/+/9b6e3c78898f12a0183edffb62d189cb716c6135

[Peter Beverloo, 2017-04-07 17:18:48]

Description was changed from

==========
Fix the settings button and UMA metrics for the message center

BUG=706658
==========

to

==========
Fix the settings button and UMA metrics for the message center

The settings button was unintentionally broken for Windows and
Linux users in 2799653004, as was gathering of some UMA. This
CL offers a slight refactoring that meets all goals.

BUG=706658
==========

[Peter Beverloo, 2017-04-07 17:18:49]

peter@chromium.org changed reviewers:
+ yhanada@chromium.org, yoshiki@chromium.org

[Peter Beverloo, 2017-04-07 17:18:59]

PTAL

[Peter Beverloo, 2017-04-07 17:19:03]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 17:19:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:07:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:07:43]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-04-10 05:07:51]

lgtm

[yoshiki, 2017-04-10 06:56:08]

Thanks! LGTM

[Peter Beverloo, 2017-04-10 17:37:48]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:38:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 18:35:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491845868311030, "parent_rev":
"f50104bb610bec50956cfe363d08c9682b930ab9", "commit_rev":
"9b6e3c78898f12a0183edffb62d189cb716c6135"}

[commit-bot: I haz the power, 2017-04-10 18:36:41]

Description was changed from

==========
Fix the settings button and UMA metrics for the message center

The settings button was unintentionally broken for Windows and
Linux users in 2799653004, as was gathering of some UMA. This
CL offers a slight refactoring that meets all goals.

BUG=706658
==========

to

==========
Fix the settings button and UMA metrics for the message center

The settings button was unintentionally broken for Windows and
Linux users in 2799653004, as was gathering of some UMA. This
CL offers a slight refactoring that meets all goals.

BUG=706658

Review-Url: https://codereview.chromium.org/2807623002
Cr-Commit-Position: refs/heads/master@{#463339}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b6e3c78898f12a0183edffb62d1...
==========

[commit-bot: I haz the power, 2017-04-10 18:36:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b6e3c78898f12a0183edffb62d1...