chrome/browser/notifications/web_notification_delegate.h - Issue 2807623002: Fix the settings button and UMA metrics for the message center

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/web_notification_delegate.h

Issue 2807623002: Fix the settings button and UMA metrics for the message center (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/web_notification_delegate.h

diff --git a/chrome/browser/notifications/web_notification_delegate.h b/chrome/browser/notifications/web_notification_delegate.h

index 78aaa6b1c8c005331de66a0d99d567c2e3e3d490..d4629fc6f4b68891d4de58e8047cc71e9cc5bf87 100644

--- a/chrome/browser/notifications/web_notification_delegate.h

+++ b/chrome/browser/notifications/web_notification_delegate.h

@@ -31,7 +31,7 @@ class WebNotificationDelegate : public NotificationDelegate {

public:

// NotificationDelegate implementation.

std::string id() const override;

- void SettingsClick() override;

+ bool SettingsClick() override;

bool ShouldDisplaySettingsButton() override;

bool ShouldDisplayOverFullscreen() const override;