Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: chrome/browser/notifications/web_notification_delegate.h

Issue 2807623002: Fix the settings button and UMA metrics for the message center (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_
6 #define CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_ 6 #define CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/feature_list.h" 10 #include "base/feature_list.h"
(...skipping 13 matching lines...) Expand all
24 24
25 // Base class for the PersistentNotificationDelegate and the 25 // Base class for the PersistentNotificationDelegate and the
26 // NotificationObjectProxy. All common functionality for displaying web 26 // NotificationObjectProxy. All common functionality for displaying web
27 // notifications is found here. 27 // notifications is found here.
28 // TODO(peter, crbug.com/596161): Migrate this functionality offered by the 28 // TODO(peter, crbug.com/596161): Migrate this functionality offered by the
29 // delegate to the NotificationDisplayService. 29 // delegate to the NotificationDisplayService.
30 class WebNotificationDelegate : public NotificationDelegate { 30 class WebNotificationDelegate : public NotificationDelegate {
31 public: 31 public:
32 // NotificationDelegate implementation. 32 // NotificationDelegate implementation.
33 std::string id() const override; 33 std::string id() const override;
34 void SettingsClick() override; 34 bool SettingsClick() override;
35 bool ShouldDisplaySettingsButton() override; 35 bool ShouldDisplaySettingsButton() override;
36 bool ShouldDisplayOverFullscreen() const override; 36 bool ShouldDisplayOverFullscreen() const override;
37 37
38 protected: 38 protected:
39 WebNotificationDelegate(content::BrowserContext* browser_context, 39 WebNotificationDelegate(content::BrowserContext* browser_context,
40 const std::string& notification_id, 40 const std::string& notification_id,
41 const GURL& origin); 41 const GURL& origin);
42 42
43 ~WebNotificationDelegate() override; 43 ~WebNotificationDelegate() override;
44 44
45 content::BrowserContext* browser_context() { return browser_context_; } 45 content::BrowserContext* browser_context() { return browser_context_; }
46 const GURL& origin() { return origin_; } 46 const GURL& origin() { return origin_; }
47 47
48 private: 48 private:
49 content::BrowserContext* browser_context_; 49 content::BrowserContext* browser_context_;
50 std::string notification_id_; 50 std::string notification_id_;
51 GURL origin_; 51 GURL origin_;
52 52
53 DISALLOW_COPY_AND_ASSIGN(WebNotificationDelegate); 53 DISALLOW_COPY_AND_ASSIGN(WebNotificationDelegate);
54 }; 54 };
55 55
56 #endif // CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_ 56 #endif // CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698