Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Unified Diff: chrome/browser/notifications/web_notification_delegate.cc

Issue 2807623002: Fix the settings button and UMA metrics for the message center (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/notifications/web_notification_delegate.h ('k') | ui/message_center/message_center_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/web_notification_delegate.cc
diff --git a/chrome/browser/notifications/web_notification_delegate.cc b/chrome/browser/notifications/web_notification_delegate.cc
index b1ed063c9b65e801554e8e705886e03e266bccf6..86671a5d043199e7aec7122fa882429179c15b2d 100644
--- a/chrome/browser/notifications/web_notification_delegate.cc
+++ b/chrome/browser/notifications/web_notification_delegate.cc
@@ -42,8 +42,13 @@ std::string WebNotificationDelegate::id() const {
return notification_id_;
}
-void WebNotificationDelegate::SettingsClick() {
+bool WebNotificationDelegate::SettingsClick() {
+#if !defined(OS_CHROMEOS)
NotificationCommon::OpenNotificationSettings(browser_context_);
+ return true;
+#else
+ return false;
+#endif
}
bool WebNotificationDelegate::ShouldDisplaySettingsButton() {
« no previous file with comments | « chrome/browser/notifications/web_notification_delegate.h ('k') | ui/message_center/message_center_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698