Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: ui/message_center/message_center_impl.cc

Issue 2807623002: Fix the settings button and UMA metrics for the message center (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/message_center/message_center_impl.cc
diff --git a/ui/message_center/message_center_impl.cc b/ui/message_center/message_center_impl.cc
index 4e90822a60c39912172e7c3b82310b7d8c69c271..982611a8d3ba8b447af4378e5ec3054609f64023 100644
--- a/ui/message_center/message_center_impl.cc
+++ b/ui/message_center/message_center_impl.cc
@@ -795,10 +795,13 @@ void MessageCenterImpl::ClickOnNotificationButton(const std::string& id,
void MessageCenterImpl::ClickOnSettingsButton(const std::string& id) {
scoped_refptr<NotificationDelegate> delegate =
notification_list_->GetNotificationDelegate(id);
+
+ bool handled_by_delegate = false;
if (delegate.get())
- delegate->SettingsClick();
+ handled_by_delegate = delegate->SettingsClick();
+
for (auto& observer : observer_list_)
- observer.OnNotificationSettingsClicked();
+ observer.OnNotificationSettingsClicked(handled_by_delegate);
}
void MessageCenterImpl::MarkSinglePopupAsShown(const std::string& id,
« no previous file with comments | « chrome/browser/notifications/web_notification_delegate.cc ('k') | ui/message_center/message_center_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698