Compile suggest_app_dialog in gyp v2

Compile suggest_app_dialog in gyp v2

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widget, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container by extracting
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2805853002
Cr-Commit-Position: refs/heads/master@{#463131}
Committed: https://chromium.googlesource.com/chromium/src/+/1fbb3695fde899fe678fbad74fbedaad1ae3242c

[oka, 2017-04-07 08:33:06]

Description was changed from

==========
Compile suggest_app_dialog.

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widgets, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container: Extracted
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
==========

to

==========
Compile suggest_app_dialog.

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widgets, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container: Extracted
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-07 08:36:29]

git cl format --js

[oka, 2017-04-07 08:37:34]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 08:37:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-04-07 08:38:05]

Description was changed from

==========
Compile suggest_app_dialog.

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widgets, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container: Extracted
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile suggest_app_dialog in gyp v2

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widgets, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container: Extracted
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-07 08:38:36]

Description was changed from

==========
Compile suggest_app_dialog in gyp v2

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widgets, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container: Extracted
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile suggest_app_dialog in gyp v2

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widget, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container: Extracted
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-07 08:39:17]

Description was changed from

==========
Compile suggest_app_dialog in gyp v2

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widget, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container: Extracted
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile suggest_app_dialog in gyp v2

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widget, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container by extracting
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-07 08:42:28]

sort

[oka, 2017-04-07 08:42:32]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 08:42:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-04-07 08:43:01]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2017-04-07 08:43:02]

PTAL.

[oka, 2017-04-07 09:36:58]

Fix unit test.

[fukino, 2017-04-07 10:45:46]

lgtm

[oka, 2017-04-07 10:59:10]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 10:59:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 11:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 11:24:16]

Dry run: This issue passed the CQ dry run.

[oka, 2017-04-08 11:10:44]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2017-04-08 11:10:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 11:35:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491649844294050,
"parent_rev": "270af5af87a83f24a120ac2417bc6ad0aafcca6f", "commit_rev":
"1fbb3695fde899fe678fbad74fbedaad1ae3242c"}

[commit-bot: I haz the power, 2017-04-08 11:36:25]

Description was changed from

==========
Compile suggest_app_dialog in gyp v2

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widget, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container by extracting
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile suggest_app_dialog in gyp v2

- Extracted needed utility functions and constants into constants.js
and web_store_utils.js
- Compiled cws_widget, which is used by SuggetAppDialog, removing the circular
dependency between app_installer and cws_widget_container by extracting
a delegator definition into a separate file.

BUG=636289
TEST=closure_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2805853002
Cr-Commit-Position: refs/heads/master@{#463131}
Committed:
https://chromium.googlesource.com/chromium/src/+/1fbb3695fde899fe678fbad74fbe...
==========

[commit-bot: I haz the power, 2017-04-08 11:36:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1fbb3695fde899fe678fbad74fbe...